Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify Public API documentation for the new nullable APIs #35046

Open
333fred opened this issue Apr 17, 2019 · 3 comments
Open

Verify Public API documentation for the new nullable APIs #35046

333fred opened this issue Apr 17, 2019 · 3 comments
Assignees
@333fred
Labels
Area-Compilers Documentation New Language Feature - Nullable Reference Types Nullable Reference Types New Language Feature - Nullable Semantic Model Nullable Semantic Model Issues
Projects
Compiler: Nullable SemanticModel Work
Milestone
Backlog

Comments

@333fred
Copy link
Member

333fred commented Apr 17, 2019

I've currently added relatively minimal documentation for the new public APIs. We should go through these docs and expand them, and do a formal review.
@333fred 333fred mentioned this issue Apr 18, 2019
Merged
@333fred
Copy link
Member Author

333fred commented May 1, 2019

GetTypeInfo will need to note the consequences of suppressions on expressions. See #32661.

@333fred 333fred mentioned this issue May 1, 2019
Closed
@333fred 333fred added New Language Feature - Nullable Semantic Model Nullable Semantic Model Issues and removed New Language Feature - Nullable Semantic Model Nullable Semantic Model Issues labels May 20, 2019
@gafter gafter added this to the 16.3 milestone Jul 16, 2019
@gafter
Copy link
Member

gafter commented Jul 16, 2019

The docs in NullableAnnotation should talk about either locations or symbols, not expressions.

@jcouv jcouv added Documentation and removed Bug labels Jul 17, 2019
@333fred 333fred moved this from TRIAGE to Misc in Compiler: Nullable SemanticModel Work Jul 18, 2019
@gafter gafter modified the milestones: 16.3, 16.4 Sep 12, 2019
@333fred
Copy link
Member Author

333fred commented Oct 9, 2019

Keeping this open for the final nullable API we end up moving to as part of the ITypeSymbol refactor, but this will be post 16.4.

@333fred 333fred modified the milestones: 16.4, Compiler.Next Oct 9, 2019
@jaredpar jaredpar modified the milestones: Compiler.Next, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@333fred 333fred

Labels
Area-Compilers Documentation New Language Feature - Nullable Reference Types Nullable Reference Types New Language Feature - Nullable Semantic Model Nullable Semantic Model Issues
Projects
Compiler: Nullable SemanticModel Work
  
Misc
Milestone
Backlog
Development

No branches or pull requests
4 participants
@jaredpar @333fred @gafter @jcouv