Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider if it would be advantageous to delay creation of ITypeSymbol instances returned by IOperation.Type API for C# #39646

Open
AlekseyTs opened this issue Nov 1, 2019 · 2 comments
Open

Consider if it would be advantageous to delay creation of ITypeSymbol instances returned by IOperation.Type API for C# #39646

AlekseyTs opened this issue Nov 1, 2019 · 2 comments
Labels
Area-Compilers Concept-Continuous Improvement Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Feature - IOperation IOperation New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
Nullable Board Compiler: Engineering Investments

Comments

@AlekseyTs
Copy link
Contributor

After #39498, public symbols and internal symbols are no longer implemented by the same objects for C#. When we create IOperation nodes, we eagerly create ITypeSymbol instances that should be returned by IOperation.Type API. The same is happening for other symbols exposed by IOperation APIs. It was suggested during PR review (#39498 (comment)) that it might be advantageous to delay creation of ITypeSymbol (and perhaps other public symbols). Capture internal symbols in IOperation nodes instead and create public symbols only when requested by a consumer.
@AlekseyTs AlekseyTs added Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality labels Nov 1, 2019
@AlekseyTs
Copy link
Contributor Author

@333fred FYI

@jcouv jcouv added this to Misc in Nullable Board Dec 10, 2019
@AlekseyTs
Copy link
Contributor Author

CC @333fred

@jaredpar jaredpar moved this from Misc to Implementation Improvements in Nullable Board Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers Concept-Continuous Improvement Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality Feature - IOperation IOperation New Language Feature - Nullable Reference Types Nullable Reference Types
Projects
Compiler: Engineering Investments
  
Triage
Nullable Board
Implementation Improvements
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlekseyTs