Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull member up didn't qualify things appropriately #39744

jasonmalinowski opened this issue Nov 9, 2019 · 0 comments


Copy link

@jasonmalinowski jasonmalinowski commented Nov 9, 2019

Version Used:

Steps to Reproduce:

  1. Have an empty class derive from a base class that is also empty. Have these be in two separate files, and no using statements in either file.
  2. In the derived class, add a method like void M(CancellationToken token) { }, and invoke add using for CancellationToken.
  3. Use "pull member up" to pull this up.

Expected Behavior: the code in the base class either qualifies CancellationToken or adds a using.
Actual Behavior: nothing happens, so the resulting code doesn't even compile.

This is perhaps related to #34427 where the customer is concerned that we aren't minimally qualifying things, or #35806 which has a much longer conversation about automatically adding usings. But it seems this is even more broken: we aren't even generating valid code at all...

@gafter gafter added the Area-IDE label Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.