Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline rename should be aware of unchangeable documents during conflict resolving #41242

Open
genlu opened this issue Jan 27, 2020 · 0 comments

Comments

@genlu
Copy link
Member

genlu commented Jan 27, 2020

This was pointed out by @jasonmalinowski in this comment:
#40816 (review)

But if there's a conflict resolution in a file that otherwise didn't have a original location, I suspect we're going to try modifying the text buffer too.

Today, this is fine because opened documents can't be unchangeable, but this might change in the future depends on the design of code generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Source Generators
  
IDE Feature Bugs When Using Source Ge...
Development

No branches or pull requests

3 participants