-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking API Change #4170
Comments
FYI. @jaredpar, @AnthonyDGreen |
Removal of overrides shouldn't be a breaking change (and we're shouldn't log them in PublicAPI.txt). Removal of the constructor is a breaking change. |
It is a breaking change if the override has default argument values which differ from those in the base definition. This doesn't apply to the case above but it's something to be aware of before suppressing overrides from the public API. |
Technically yes. Would we ever do this - no. And it would result in different behavior between C# and VB (C# calls the base method, VB calls the override). |
Fixed in #4186 (documented the breaking change) |
PR #4169 Makes a breaking change to the Public API as part of the Toolset Update. Specifically it removes the following from
src\Compiles\VisualBasic\Portable\PublicAPI.txt
:Microsoft.CodeAnalysis.VisualBasic.VisualBasicCommandLineParser.New(isInteractive As Boolean = False) -> Void
Overrides Microsoft.CodeAnalysis.VisualBasic.VisualBasicCommandLineParser.RegularFileExtension() -> String
Overrides Microsoft.CodeAnalysis.VisualBasic.VisualBasicCommandLineParser.ScriptFileExtension() -> String
A decision will need to be made on whether or not we need to keep this breaking change or if we should take on the public API increases that will be required to revert it.
The text was updated successfully, but these errors were encountered: