Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move implementations of CompletionServiceWithProviders to MEF provider only #42367

Open
genlu opened this issue Mar 12, 2020 · 2 comments
Open

Move implementations of CompletionServiceWithProviders to MEF provider only #42367

genlu opened this issue Mar 12, 2020 · 2 comments
Assignees
@genlu
Labels
Area-IDE Concept-Continuous Improvement
Milestone
Backlog

Comments

@genlu
Copy link
Member

genlu commented Mar 12, 2020 •
edited

We are considering deprecate and unhook builtin provider API in next major release.
@genlu genlu added the Area-IDE label Mar 12, 2020
@genlu genlu changed the title Move consumers of CompletionServiceWithProviders to MEF provider only Move implementations of CompletionServiceWithProviders to MEF provider only Mar 12, 2020
@genlu genlu mentioned this issue Mar 12, 2020
Merged
@genlu
Copy link
Member Author

genlu commented Mar 13, 2020

FYI @brettfo @uniqueiniquity
Here's an example:
https://github.com/dotnet/roslyn/blob/master/src/Features/CSharp/Portable/Completion/CompletionProviders/KeywordCompletionProvider.cs#L20

@uniqueiniquity
Copy link
Contributor

By the next major release, it's probable that we will be using LSP for completion instead of Roslyn, so this may be a non-issue by that point.

@jinujoseph jinujoseph added this to the Backlog milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genlu genlu

Labels
Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@genlu @uniqueiniquity @jinujoseph