Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review use of Symbol.ToString() and Symbol.ToDisplayString() in binding #43206

Open
cston opened this issue Apr 8, 2020 · 0 comments
Open

Review use of Symbol.ToString() and Symbol.ToDisplayString() in binding #43206

cston opened this issue Apr 8, 2020 · 0 comments
Labels
Area-Compilers

Comments

@cston
Copy link
Member

cston commented Apr 8, 2020

Symbol.ToString() and Symbol.ToDisplayString() are implemented with SymbolDisplay.ToDisplayString(ISymbol). In the C# compiler, the ISymbol representation is a separate instance from the underlying Symbol, and if SymbolDisplay.ToDisplayString(ISymbol) is called while the underlying Symbol is being constructed, the symbol may be incomplete, perhaps leading to a cycle.

See #43181 (comment)

cc @AlekseyTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cston