Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce correct init setter method name with winmd output #44684

Open
RikkiGibson opened this issue May 29, 2020 · 1 comment
Open

Produce correct init setter method name with winmd output #44684

RikkiGibson opened this issue May 29, 2020 · 1 comment

Comments

@RikkiGibson
Copy link
Contributor

Looks like it should be put_PropName not set_PropName in this scenario. I assume it is not hard to check the output kind to figure out what to pass here.

@RikkiGibson RikkiGibson added this to Needs Triage in Records Board via automation May 29, 2020
@jaredpar jaredpar moved this from Needs Triage to Later in Records Board Jun 2, 2020
@jaredpar jaredpar added the Bug label Jun 22, 2020
@AlekseyTs AlekseyTs added the Test Test failures in roslyn-CI label Jul 12, 2020
@AlekseyTs
Copy link
Contributor

I believe that after recent changes around implementation of SynthesizedRecordPropertySymbol, change what it derives from, etc. we no longer need to worry about handling naming for accessors. Of course, it would be good to have a test verifying the fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Records Board
  
Later
Development

No branches or pull requests

3 participants