Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Analysis Should Not Include GlobalSuppressions.cs #50233

Open
vsfeedback opened this issue Jan 4, 2021 · 3 comments
Open

Code Analysis Should Not Include GlobalSuppressions.cs #50233

vsfeedback opened this issue Jan 4, 2021 · 3 comments
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved. Resolution-By Design The behavior reported in the issue matches the current design
Projects
IDE: Design review

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.

[severity:It's more difficult to complete my work]
When running Analyze in VS2019, it should not check the GlobalSuppressions.cs. Currently, it is included and I feel it should not be included. Or make this a settting.

Original Comments

Feedback Bot on 12/28/2020, 07:05 PM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Original Solutions

(no solutions)
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 4, 2021
@mavasani mavasani added Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved. Resolution-By Design The behavior reported in the issue matches the current design and removed Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 4, 2021
@mavasani mavasani added this to In Queue in IDE: Design review via automation Jan 4, 2021
@mavasani mavasani moved this from In Queue to On deck in IDE: Design review Jan 4, 2021
@mavasani
Copy link
Member

mavasani commented Jan 4, 2021 •
edited

When running Analyze in VS2019, it should not check the GlobalSuppressions.cs.

IMO, this file is no different from other global assembly attributes files in a project and should not get any special treatment. Recommendation should be for users to turn off analyzers on this file via editorconfig, if they prefer such a setting: https://docs.microsoft.com/en-us/visualstudio/code-quality/use-roslyn-analyzers?view=vs-2019#configure-generated-code

[GlobalSuppressions.cs]
generated_code = true

@mavasani mavasani moved this from On deck to Next meeting in IDE: Design review Jan 11, 2021
@sharwell sharwell moved this from Next meeting to Need Update in IDE: Design review Jan 11, 2021
@Cosifne
Copy link
Member

Cosifne commented Jan 12, 2021

Design meeting:
This is by design. But we are open to add auto-generated comments if we know existing user scenario

@Cosifne Cosifne moved this from Need Update to Complete in IDE: Design review Jan 12, 2021
@Youssef1313
Copy link
Member

@mavasani Should this get closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved. Resolution-By Design The behavior reported in the issue matches the current design
Projects
IDE: Design review
Status: Complete
IDE: Design review
  
Complete
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mavasani @Cosifne @Youssef1313 @vsfeedback @Dotnet-GitSync-Bot