Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider filling argument values directly instead of through a snippet function #50760

Open
sharwell opened this issue Jan 25, 2021 · 1 comment
Open

Consider filling argument values directly instead of through a snippet function #50760

sharwell opened this issue Jan 25, 2021 · 1 comment
Assignees
@sharwell
Labels
Area-IDE Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality IDE-IntelliSense Completion, Signature Help, Quick Info IntelliSense-Argument Completion Insert full method call
Milestone
Backlog

Comments

@sharwell
Copy link
Member

sharwell commented Jan 25, 2021 •
edited

This change would avoid the need to resolve parameter symbols more than once during argument evaluation. See #49916 (comment).

This refactoring would also eliminate the need for ArgumentValue as a snippet function, which is the subject of #49916 (comment).
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 25, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@sharwell sharwell mentioned this issue Jan 25, 2021
Merged
@jinujoseph jinujoseph added Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 28, 2021
@jinujoseph jinujoseph added this to the 16.10 milestone Jan 28, 2021
@sharwell sharwell added IDE-IntelliSense Completion, Signature Help, Quick Info IntelliSense-Argument Completion Insert full method call labels Feb 2, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, Backlog Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality IDE-IntelliSense Completion, Signature Help, Quick Info IntelliSense-Argument Completion Insert full method call
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@jaredpar @sharwell @jinujoseph