ExtractMethodCodeRefactoringProvider crashes with System.InvalidCastException

[vsfeedback]

🔗 See AB#1269217

This issue has been moved from a ticket on Developer Community.

---

[severity:It bothers me. A fix would be nice]

While editing code in VS2019:

System.InvalidCastException : Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Symbols.Retargeting.RetargetingAssemblySymbol' to type 'Microsoft.CodeAnalysis.CSharp.Symbols.SourceAssemblySymbol'.
   at Microsoft.CodeAnalysis.CSharp.DefiniteAssignmentPass.. ctor(CSharpCompilation compilation,Symbol member,BoundNode node,EmptyStructTypeCache emptyStructs,Boolean trackUnassignments,HashSet`1 initiallyAssignedVariables)
   at Microsoft.CodeAnalysis.CSharp.UnassignedVariablesWalker.Analyze(CSharpCompilation compilation,Symbol member,BoundNode node,Boolean convertInsufficientExecutionStackExceptionToCancelledByStackGuardException)
   at Microsoft.CodeAnalysis.CSharp.CSharpDataFlowAnalysis.get_UnassignedVariables()
   at Microsoft.CodeAnalysis.CSharp.CSharpDataFlowAnalysis.get_DataFlowsIn()
   at Microsoft.CodeAnalysis.CSharp.CSharpDataFlowAnalysis.get_Succeeded()
   at Microsoft.CodeAnalysis.CSharp.CSharpDataFlowAnalysis.AnalyzeReadWrite()
   at Microsoft.CodeAnalysis.CSharp.CSharpDataFlowAnalysis.get_Captured()
   at Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.GenerateVariableInfoMap(Boolean bestEffort,SemanticModel model,DataFlowAnalysis dataFlowAnalysisData,Dictionary`2 symbolMap,IDictionary`2& variableInfoMap,List`1& failedVariables)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.Analyzer.AnalyzeAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.MethodExtractor.ExtractMethodAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.ExtractMethod.AbstractExtractMethodService`3.ExtractMethodAsync[TValidator,TExtractor,TResult](<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.ExtractMethodAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.GetCodeActionsAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.ExtractMethod.ExtractMethodCodeRefactoringProvider.ComputeRefactoringsAsync(<Unknown Parameters>)
   at async Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringService.GetRefactoringFromProviderAsync(<Unknown Parameters>)
   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)

---

Original Comments

Feedback Bot on 1/24/2021, 10:07 PM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

---

Original Solutions

(no solutions)

[jaredpar]

@AlekseyTs tentatively put this in 16.9 as it didn't come with a repro and hence unclear how severe this is. Based on how common the repro is we should punt to 16.10.

[daviburg]

I attached an issue reproduction recording from the VS feedback tool when reporting this. Does it not show up?

[AlekseyTs]

I don't think this issue is actionable. There is something special about the scenario, otherwise there would be a lot of complains about Extract Method refactoring not working. In order to figure out the root cause, we would either need a crash dump with heap, or reliable repro steps.

[daviburg]

Sorry to hear. How may I generate a crash dump with heap next time this problem surfaces?

[AlekseyTs]

@sharwell Is Watson report sent automatically in cases like this? Is there a way to locate it? Are there other ways to debug the refactoring crash?

[AlekseyTs]

Closing as "No Repro" for now.