Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ArgumentProvider caching to a language service #50897

Open
sharwell opened this issue Jan 29, 2021 · 0 comments
Open

Move ArgumentProvider caching to a language service #50897

sharwell opened this issue Jan 29, 2021 · 0 comments
Assignees
@sharwell
Labels
Area-IDE Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality IDE-IntelliSense Completion, Signature Help, Quick Info IntelliSense-Argument Completion Insert full method call
Milestone
Backlog

Comments

@sharwell
Copy link
Member

Tracking TODO in #49916.

Currently argument provider caching is implemented directly in AbstractSnippetExpansionClient. Since the argument providers are specific to workspace instances, this cache should move to an ILanguageService which operates similar to CompletionServiceWithProviders.
@sharwell sharwell added Area-IDE Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality labels Jan 29, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 29, 2021
@sharwell sharwell self-assigned this Jan 29, 2021
@sharwell sharwell mentioned this issue Jan 29, 2021
Merged
@jinujoseph jinujoseph removed the untriaged Issues and PRs which have not yet been triaged by a lead label Feb 2, 2021
@jinujoseph jinujoseph added this to the 16.10 milestone Feb 2, 2021
@sharwell sharwell added IDE-IntelliSense Completion, Signature Help, Quick Info IntelliSense-Argument Completion Insert full method call labels Feb 2, 2021
@jinujoseph jinujoseph modified the milestones: 16.10, Backlog Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Concept-Design Debt Engineering Debt, Design Debt, or poor product code quality IDE-IntelliSense Completion, Signature Help, Quick Info IntelliSense-Argument Completion Insert full method call
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@sharwell @jinujoseph