Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider exposing SignatureComparer #52424

Open
kzu opened this issue Apr 5, 2021 · 0 comments
Open

Consider exposing SignatureComparer #52424

kzu opened this issue Apr 5, 2021 · 0 comments
Assignees
Labels
Area-Compilers Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request
Milestone

Comments

@kzu
Copy link
Contributor

kzu commented Apr 5, 2021

Consider the scenario where a source generator must check for the presence of a certain member by signature (i.e. to determine if the class implements a certain interface already, or has a given convention-based member) to determine whether certain code generation must happen or not.

Currently, the SignatureComparer is an internal shared utility class, which prevents this scenario.

Note: attempting to extract just this class from Roslyn' source is a non-trivial endeavor since it has dependencies on the internal SymbolEquivalenceComparer class and all its nested classes.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 5, 2021
@jaredpar jaredpar added Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 20, 2021
@jaredpar jaredpar added this to the Compiler.Next milestone Apr 20, 2021
@jaredpar jaredpar modified the milestones: Compiler.Next, Backlog Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request
Projects
None yet
Development

No branches or pull requests

3 participants