Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update corefx dependencies to 6.0.0 #57875

Open
genlu opened this issue Nov 19, 2021 · 5 comments
Open

Update corefx dependencies to 6.0.0 #57875

genlu opened this issue Nov 19, 2021 · 5 comments
Assignees
@RikkiGibson
Labels
Area-Infrastructure Bug
Milestone
17.6 P2

Comments

@genlu
Copy link
Member

genlu commented Nov 19, 2021 •
edited by jaredpar

VS is moving to 6.0, we should keep Roslyn in-sync

Specifically this should include:

  • System.Collections.Immutable
  • System.Reflection.Metadata
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 19, 2021
@genlu genlu mentioned this issue Nov 19, 2021
Merged
@genlu genlu added this to the 17.1 milestone Nov 19, 2021
@jaredpar jaredpar added Bug and removed Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 19, 2021
@jaredpar jaredpar assigned RikkiGibson and unassigned jaredpar Nov 19, 2021
@teo-tsirpanis teo-tsirpanis mentioned this issue Nov 19, 2021
Closed
@RikkiGibson RikkiGibson mentioned this issue Jan 3, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: 17.1, 17.2 Jan 21, 2022
@RikkiGibson
Copy link
Contributor

Based on #58570 it looks like we'll need to entirely move off of .NET Standard 1.3 and NET 4.5 in Microsoft.CodeAnalysis.Debugging.Package.csproj. I thought the debugger recently made a change which should make it possible for us to do this.

@jcouv jcouv modified the milestones: 17.2, 17.3 May 14, 2022
@RikkiGibson
Copy link
Contributor

@genlu is there any timeline in which this needs to happen?

@alrz
Copy link
Contributor

alrz commented Sep 5, 2022 •
edited

VS is moving to 6.0, we should keep Roslyn in-sync

Is there a hidden context here or it's just what it says?

@RikkiGibson
Copy link
Contributor

I wasn't aware of any other context. I think keeping the versions in sync here just helps us build the product in a more consistent/predictable way.

@RikkiGibson
Copy link
Contributor

It's possible that forgetting about this issue has lead to #63780 :/

@arkalyanms arkalyanms modified the milestones: 17.3, 17.6 P2 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RikkiGibson RikkiGibson

Labels
Area-Infrastructure Bug
Projects
None yet
Milestone
17.6 P2
Development

Successfully merging a pull request may close this issue.

Update some netcore packages to 6.0.0 RikkiGibson/roslyn
6 participants
@jaredpar @genlu @alrz @RikkiGibson @jcouv @arkalyanms