Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add perf related integration tests for diagnostics #58445

Open
mavasani opened this issue Dec 21, 2021 · 1 comment
Open

Add perf related integration tests for diagnostics #58445

mavasani opened this issue Dec 21, 2021 · 1 comment
Labels
Area-Analyzers Performance-Scenario-Diagnostics This issue affects diagnostics computation performance for lightbulb, background analysis, tagger. Test Test failures in roslyn-CI
Milestone
Backlog

Comments

@mavasani
Copy link
Member

It'd be interesting to see what integration tests would look like here, especially with @sharwell's new integration test framework. Can we actually test open/close/reopen and ensure there's not multiple entries where there shouldn't be?

Originally posted by @jasonmalinowski in #58406 (review)
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 21, 2021
@mavasani mavasani mentioned this issue Dec 21, 2021
Merged
@sharwell
Copy link
Member

Can we actually test open/close/reopen and ensure there's not multiple entries where there shouldn't be?

In theory, yes, but the GC isn't the most predictable thing in testing.

@jinujoseph jinujoseph added Test Test failures in roslyn-CI and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 4, 2022
@jinujoseph jinujoseph added this to the Backlog milestone Jan 4, 2022
@mavasani mavasani added the Performance-Scenario-Diagnostics This issue affects diagnostics computation performance for lightbulb, background analysis, tagger. label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Analyzers Performance-Scenario-Diagnostics This issue affects diagnostics computation performance for lightbulb, background analysis, tagger. Test Test failures in roslyn-CI
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@sharwell @mavasani @jinujoseph