Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Implement interface' should allow implicit implementation of non-public interface members #62014

Open
Youssef1313 opened this issue Jun 19, 2022 · 0 comments
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved.
Milestone

Comments

@Youssef1313
Copy link
Member

interface IA
{
    internal void M();
    internal int P1 { get; set; }
    int P2 { get; internal set; }
}

class A : IA
{
}

Currently only "Implement all members explicitly" is offered.

Expected behavior from implementing interface implicitly is:

interface IA
{
    internal void M();
    internal int P1 { get; set; }
    int P2 { get; internal set; }
    int P3 { get; set; }
}

class A : IA
{
    public void M()
    {
        throw new NotImplementedException();
    }

    public int P1 { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }

    public int P2 { get => throw new NotImplementedException(); set => throw new NotImplementedException(); }
}
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 19, 2022
@vatsalyaagrawal vatsalyaagrawal added Feature Request Need Design Review The end user experience design needs to be reviewed and approved. and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 8, 2022
@vatsalyaagrawal vatsalyaagrawal added this to In Queue in IDE: Design review via automation Jul 8, 2022
@vatsalyaagrawal vatsalyaagrawal added this to the Backlog milestone Jul 8, 2022
@vatsalyaagrawal vatsalyaagrawal moved this from In Queue to Need Proposal in IDE: Design review Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved.
Projects
Status: Need Proposal
IDE: Design review
  
Need Proposal
Development

No branches or pull requests

2 participants