Error List not showing suppressed diagnostics

[Youssef1313]

Version Used:

17.3 Preview 2

Error shows before suppression, but didn't show after suppression

Note that I selected "Suppressed" from the Error List filter (which is off by default).

(Same applies to compiler warnings)

cc @mavasani

[mavasani]

@Youssef1313 I am unable to reproduce this on the latest internal dogfood builds:

One thing I note is that your repro shows all Suppression State values as <blank>, there are no Active, N/A or Suppressed entries. I am wondering if this is some intermittent error list bug. Can you check if you can reproduce this on 17.4 Preview1: https://docs.microsoft.com/en-us/visualstudio/releases/2022/release-notes-preview?

[Youssef1313]

@mavasani, Yes I can repro on 17.4 P1

• Warning is shown when there is no suppression:
  

• Warning doesn't show as suppressed after suppression
  

• Version:
  

[mavasani]

Interesting. I just checked on 17.3 release drop and it still doesn't reproduce for me. I am not sure why your Suppression State column is showing up as blank. Can you check the experience on RoslynDev hive? I presume you don't hit the breakpoint below?

roslyn/src/VisualStudio/Core/Def/TableDataSource/VisualStudioBaseDiagnosticListTable.LiveTableDataSource.cs

Lines 409 to 411 in 2546616

	case StandardTableKeyNames.SuppressionState:
	content = data.IsSuppressed ? SuppressionState.Suppressed : SuppressionState.Active;
	return true;

[Youssef1313]

Sure, I'll check that as soon as I can.

[mavasani]

@Youssef1313 any luck?

[Youssef1313]

Not yet :(
I got quite busy with my internship. I should be able to test in two weeks or so. You can assign me so that I don't forget.

[Youssef1313]

@mavasani Sorry for the delay here. I'm trying to reproduce this in 17.4 P1, but I now cannot find "Suppression State" in error list at all:

"Show Columns" doesn't have it as well:

[mavasani]

@Youssef1313 That is interesting. I just updated to the latest internal dogfood build and can see the column:

I am not sure why this column is behaving specially for you :-)

[mavasani]

I confirmed with @Evangelink offline that he is also able to see the Suppression State column and correct filtering for the entries based on the chosen filters for this column. He verified the same on 17.3.5 as well as latest preview for 17.4.

I am going to try this on a fresh install of a Community sku of VS and get back to you.

[Youssef1313]

I'll also re-test once I get home back.
If I could repro, I'll try to debug it on my own, and I can give you remote access via Zoom or similar software if necessary to investigate further.

[Youssef1313]

@mavasani The column appears when I have Roslyn.sln open, but it doesn't for a new project. 😕

[Evangelink]

@Youssef1313 Could you zip your project so we can try with exact same project (this would leave VS or extensions)? Also, are you still on 17.4P1? And are you using Community sku?

[Youssef1313]

Yeah I'm on 17.4 Preview 1. It's really just a new project.

ConsoleApp9.zip

and yes, I'm using community.

[Evangelink]

Awesome! I don't understand but hey I have the same issue on that project on my personal machine (Microsoft Visual Studio Community 2022 (64-bit) - Preview Version 17.4.0 Preview 2.0). But when opening RoslynAnalyzers solution column appears, and I can filter.

EDIT: Found the issue... it's linked to <ImplicitUsings>enable</ImplicitUsings>. As soon as I comment the line, column show up. @Youssef1313 could you confirm you see the same thing?

EDIT2: I confirm this is also the case with Pro and Entreprise editions.

[mavasani]

Another possible cause could be LSP pull diagnostics, see #65172. @Youssef1313 can you confirm if you have pull diagnostics enabled or not?

[Youssef1313]

@mavasani Yes I have pull diagnostics enabled.

[Youssef1313]

EDIT: Found the issue... it's linked to <ImplicitUsings>enable</ImplicitUsings>. As soon as I comment the line, column show up. @Youssef1313 could you confirm you see the same thing?

I can't imagine why ImplicitUsings would affect error list.

[Youssef1313]

@mavasani Should I close as a duplicate of #65172 ?

[mavasani]

Yes, if disabling pull diagnostics fixes the issue then go ahead

[Youssef1313]

Yes, it does fix it. I'm going to close out.