Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all warnings and errors set in EditorConfig should be the default setting in Code Cleanup #62651

Open
mikadumont opened this issue Jul 14, 2022 · 5 comments
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved.
Milestone

Comments

@mikadumont
Copy link
Contributor

Fix all warnings and errors set in EditorConfig should automatically be promoted. A user should be able to set their EditorConfig and then run code cleanup and it all works. We can have a third profile that represents EditorConfig settings and have it be the default. Having this be the default experience will solve current discoverability issues and overhead of needing to configure both an EidtorConfig and Code Cleanup.

image

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 14, 2022
@mikadumont
Copy link
Contributor Author

Investigating this a bit more profiles currently dont roam so users have gotten used to loosing their settings after each re-install. Therefore overriding settings for the EditorConfig one may not upset users since theyre used to this behavior especially if there will now be a benefit to them loosing it.

@vatsalyaagrawal vatsalyaagrawal added Need Design Review The end user experience design needs to be reviewed and approved. and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 18, 2022
@vatsalyaagrawal vatsalyaagrawal added this to In Queue in IDE: Design review via automation Jul 18, 2022
@vatsalyaagrawal vatsalyaagrawal added this to the Backlog milestone Jul 18, 2022
@mikadumont mikadumont moved this from In Queue to On deck in IDE: Design review Jul 18, 2022
@sharwell sharwell moved this from On deck to Need Update in IDE: Design review Jul 18, 2022
@genlu
Copy link
Member

genlu commented Jul 18, 2022

Design meeting notes:

Conclusion: we'd like to address the UX issue that everyone still need to change their setting individually even if there's editorconfig, but making "fix all warn/error of editorconfig" default could have negative perf impact.

Next step:

  • Demonstrate with experiment that no perf impact if no warn/err set in editorconfig, or if there is warn/err set, we don't impact perf when no such diagnostics exist.
  • Discuss with Editor team, explore a better solution to expose this capability.

@scottkuhl
Copy link

Conclusion: we'd like to address the UX issue that everyone still need to change their setting individually even if there's editorconfig, but making "fix all warn/error of editorconfig" default could have negative perf impact.

For reference, I believe what you are addressing here is this feedback in the Developer Community that is currently Under Review: Provide a way to share Code Cleanup profiles as related to EditorConfig

@yitzhaks
Copy link

There may be a middle ground here. We can allow configuring the cleanup profiles in the .editorconfig file. This will allow users to create a shared cleanup profile and make it as lightweight or intensive as they wish.

@bt-Knodel
Copy link

bt-Knodel commented Apr 17, 2024

This option for us adds Obsolete everywhere in code. Is there a setting in EditorConfig that prevents code modifications like adding Obsolete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Feature Request Need Design Review The end user experience design needs to be reviewed and approved.
Projects
Status: Need Update
IDE: Design review
  
Need Update
Development

No branches or pull requests

6 participants