Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error list UX/functional issue with LSP pull diagnostics enabled #65936

Open
mavasani opened this issue Dec 12, 2022 · 0 comments
Open

Error list UX/functional issue with LSP pull diagnostics enabled #65936

mavasani opened this issue Dec 12, 2022 · 0 comments
Assignees
Labels
Area-IDE Bug LSP issues related to the roslyn language server protocol implementation Tenet-User Friendly Accessibility-related functionality is broken (e.g. high-DPI, key mnemonics, screen reader, etc.)
Milestone

Comments

@mavasani
Copy link
Member

mavasani commented Dec 12, 2022

#65935 tracks performance issues with LSP pull diagnostics enabled. While working on filing that issue, I also identified a functional/UX issue in the error list.

Repro Steps:

  1. Execute the repro steps in LSP pull diagnostics performance issues in squiggles + error list #65935 and notice the changes to the title of the error list from Error List... to Error List, i.e. error list transitioning to steady state.

LspPullDiagnostics_AnalyzersEnabled

You can note in the above demo that Error List... very quickly changes to Error List after an edit, even though both the error list and the squiggles have not been updated for the latest snapshot. It takes 10s of additional seconds before the error list and the squiggles get updated. This is due to the underlying performance issue tracked in #65935. However, regardless of the bad performance, the error list title should remain as Error List... until the diagnostics state is not up-to-date, and it seems that is not the case with LSP pull diagnostics enabled. Notice the last demo gif in #65935 for Actual behavior - LSP pull diagnostics disabled + analyzers enabled for current document, and you can see that this is indeed the case with LSP pull diagnostics disabled.

I think that even if we fix the performance issue #65935, we also need to fix the functional/UX issue above and make sure that the user is clearly aware that squiggles and error list are still refreshing.

@mavasani mavasani added Bug Area-IDE Tenet-User Friendly Accessibility-related functionality is broken (e.g. high-DPI, key mnemonics, screen reader, etc.) LSP issues related to the roslyn language server protocol implementation labels Dec 12, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Dec 12, 2022
@arkalyanms arkalyanms added this to the 18.0 milestone Aug 4, 2023
@arkalyanms arkalyanms removed the untriaged Issues and PRs which have not yet been triaged by a lead label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug LSP issues related to the roslyn language server protocol implementation Tenet-User Friendly Accessibility-related functionality is broken (e.g. high-DPI, key mnemonics, screen reader, etc.)
Projects
None yet
Development

No branches or pull requests

2 participants