Remove allocations from IsCustomAttributeDefined (#44694)

dotnet · Nov 15, 2020 · 25260d1 · 25260d1
1 parent 7690431
commit 25260d1
Showing 1 changed file with 23 additions and 6 deletions.
diff --git a/src/coreclr/src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs b/src/coreclr/src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs
@@ -1115,32 +1115,49 @@ internal static bool IsAttributeDefined(RuntimeModule decoratedModule, int decor
         private static bool IsCustomAttributeDefined(
             RuntimeModule decoratedModule, int decoratedMetadataToken, RuntimeType? attributeFilterType, int attributeCtorToken, bool mustBeInheritable)
         {
-            CustomAttributeRecord[] car = CustomAttributeData.GetCustomAttributeRecords(decoratedModule, decoratedMetadataToken);
+            MetadataImport scope = decoratedModule.MetadataImport;
+
+            scope.EnumCustomAttributes(decoratedMetadataToken, out MetadataEnumResult attributeTokens);
+
+            if (attributeTokens.Length == 0)
+            {
+                return false;
+            }
 
+            CustomAttributeRecord record = default;
             if (attributeFilterType != null)
             {
                 Debug.Assert(attributeCtorToken == 0);
 
-                MetadataImport scope = decoratedModule.MetadataImport;
                 RuntimeType.ListBuilder<object> derivedAttributes = default;
 
-                for (int i = 0; i < car.Length; i++)
+                for (int i = 0; i < attributeTokens.Length; i++)
                 {
-                    if (FilterCustomAttributeRecord(car[i].tkCtor, in scope,
+                    scope.GetCustomAttributeProps(attributeTokens[i],
+                        out record.tkCtor.Value, out record.blob);
+
+                    if (FilterCustomAttributeRecord(record.tkCtor, in scope,
                         decoratedModule, decoratedMetadataToken, attributeFilterType, mustBeInheritable, ref derivedAttributes,
                         out _, out _, out _))
+                    {
                         return true;
+                    }
                 }
             }
             else
             {
                 Debug.Assert(attributeFilterType == null);
                 Debug.Assert(!MetadataToken.IsNullToken(attributeCtorToken));
 
-                for (int i = 0; i < car.Length; i++)
+                for (int i = 0; i < attributeTokens.Length; i++)
                 {
-                    if (car[i].tkCtor == attributeCtorToken)
+                    scope.GetCustomAttributeProps(attributeTokens[i],
+                        out record.tkCtor.Value, out record.blob);
+
+                    if (record.tkCtor == attributeCtorToken)
+                    {
                         return true;
+                    }
                 }
             }