Dispose transient CFData in Interop.AppleCrypto.X509GetRawData

dotnet · Jun 21, 2021 · 44bb2ad · 44bb2ad
1 parent 0cdd423
commit 44bb2ad
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/...ibraries/Common/src/Interop/OSX/System.Security.Cryptography.Native.Apple/Interop.X509.cs b/...ibraries/Common/src/Interop/OSX/System.Security.Cryptography.Native.Apple/Interop.X509.cs
@@ -55,18 +55,21 @@ internal static byte[] X509GetRawData(SafeSecCertificateHandle cert)
                 out data,
                 out osStatus);
 
-            if (ret == 1)
+            using (data)
             {
-                return CoreFoundation.CFGetData(data);
+                if (ret == 1)
+                {
+                    return CoreFoundation.CFGetData(data);
+                }
+
+                if (ret == 0)
+                {
+                    throw CreateExceptionForOSStatus(osStatus);
+                }
+
+                Debug.Fail($"Unexpected return value {ret}");
+                throw new CryptographicException();
             }
-
-            if (ret == 0)
-            {
-                throw CreateExceptionForOSStatus(osStatus);
-            }
-
-            Debug.Fail($"Unexpected return value {ret}");
-            throw new CryptographicException();
         }
 
         internal static SafeSecKeyRefHandle X509GetPrivateKeyFromIdentity(SafeSecIdentityHandle identity)