Fix race problem in configuration tests (#93711)

src/libraries/Microsoft.Extensions.Configuration.Binder/tests/Common/ConfigurationBinderTests.cs

@@ -736,37 +736,47 @@ public void GetCanReadInheritedProperties()
             Assert.Equal("Derived:Sup", options.Virtual);
         }
 
+        private static readonly object _syncLock = new object();
+
         [Fact]
         public void GetCanReadStaticProperty()
         {
-            var dic = new Dictionary<string, string>
+            // The test uses ComplexOptions.StaticProperty which is possible to be changed by other tests.
+            lock (_syncLock)
             {
-                {"StaticProperty", "stuff"},
-            };
-            var configurationBuilder = new ConfigurationBuilder();
-            configurationBuilder.AddInMemoryCollection(dic);
-            var config = configurationBuilder.Build();
-            var options = new ComplexOptions();
-            config.Bind(options);
+                var dic = new Dictionary<string, string>
+                {
+                    {"StaticProperty", "stuff"},
+                };
+                var configurationBuilder = new ConfigurationBuilder();
+                configurationBuilder.AddInMemoryCollection(dic);
+                var config = configurationBuilder.Build();
+                var options = new ComplexOptions();
+                config.Bind(options);
 
-            Assert.Equal("stuff", ComplexOptions.StaticProperty);
+                Assert.Equal("stuff", ComplexOptions.StaticProperty);
+            }
         }
 
         [Fact]
         public void BindCanReadStaticProperty()
         {
-            var dic = new Dictionary<string, string>
+            // The test uses ComplexOptions.StaticProperty which is possible to be changed by other tests.
+            lock (_syncLock)
             {
-                {"StaticProperty", "other stuff"},
-            };
-            var configurationBuilder = new ConfigurationBuilder();
-            configurationBuilder.AddInMemoryCollection(dic);
-            var config = configurationBuilder.Build();
+                var dic = new Dictionary<string, string>
+                {
+                    {"StaticProperty", "other stuff"},
+                };
+                var configurationBuilder = new ConfigurationBuilder();
+                configurationBuilder.AddInMemoryCollection(dic);
+                var config = configurationBuilder.Build();
 
-            var instance = new ComplexOptions();
-            config.Bind(instance);
+                var instance = new ComplexOptions();
+                config.Bind(instance);
 
-            Assert.Equal("other stuff", ComplexOptions.StaticProperty);
+                Assert.Equal("other stuff", ComplexOptions.StaticProperty);
+            }
         }
 
         [Fact]
@@ -2342,7 +2352,7 @@ public static void TestBindingInitializedAbstractMember()
             ClassWithAbstractProp c = new();
             c.AbstractProp = new Derived();
             configuration.Bind(c);
-            Assert.Equal(1, c.AbstractProp.Value);            
+            Assert.Equal(1, c.AbstractProp.Value);
         }
 
         [Fact]
@@ -2351,9 +2361,9 @@ public static void TestBindingUninitializedAbstractMember()
             IConfiguration configuration = TestHelpers.GetConfigurationFromJsonString(@"{ ""AbstractProp"": {""Value"":1} }");
             ClassWithAbstractProp c = new();
             c.AbstractProp = null;
-            Assert.Throws<InvalidOperationException>(() => configuration.Bind(c));        
+            Assert.Throws<InvalidOperationException>(() => configuration.Bind(c));
         }
-        
+
         [Fact]
         public void GetIConfigurationSection()
         {
@@ -2465,8 +2475,8 @@ class MockConfigurationRoot : ConfigurationRoot, IConfigurationRoot
             public MockConfigurationRoot(IList<IConfigurationProvider> providers) : base(providers)
             { }
 
-            IConfigurationSection IConfiguration.GetSection(string key) => 
-                this[key] is null ? null : new ConfigurationSection(this, key); 
+            IConfigurationSection IConfiguration.GetSection(string key) =>
+                this[key] is null ? null : new ConfigurationSection(this, key);
         }
     }
 }