Skip to content

Commit

Permalink
Disable failing arm64 win10 Graphics.FromHdc tests (#56732)
Browse files Browse the repository at this point in the history
* Disable arm64-win10 tests preventing clean build

* Use ActiveIssue with conditional
  • Loading branch information
mateoatr committed Aug 2, 2021
1 parent f83a9d9 commit 643ab28
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/libraries/System.Drawing.Common/tests/GraphicsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public static IEnumerable<object[]> FromHdc_TestData()
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/22221", TestPlatforms.AnyUnix)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51097", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process), nameof(PlatformDetection.IsWindows10OrLater))]
[ConditionalTheory(Helpers.IsDrawingSupported)]
[MemberData(nameof(FromHdc_TestData))]
public void FromHdc_ValidHdc_ReturnsExpected(IntPtr hdc)
Expand All @@ -110,6 +111,7 @@ public void FromHdc_ValidHdc_ReturnsExpected(IntPtr hdc)
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/22221", TestPlatforms.AnyUnix)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51097", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process), nameof(PlatformDetection.IsWindows10OrLater))]
[ConditionalTheory(Helpers.IsDrawingSupported)]
[MemberData(nameof(FromHdc_TestData))]
public void FromHdc_ValidHdcWithContext_ReturnsExpected(IntPtr hdc)
Expand All @@ -122,6 +124,7 @@ public void FromHdc_ValidHdcWithContext_ReturnsExpected(IntPtr hdc)
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/22221", TestPlatforms.AnyUnix)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51097", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process), nameof(PlatformDetection.IsWindows10OrLater))]
[ConditionalTheory(Helpers.IsDrawingSupported)]
[MemberData(nameof(FromHdc_TestData))]
public void FromHdcInternal_GetDC_ReturnsExpected(IntPtr hdc)
Expand Down Expand Up @@ -258,6 +261,7 @@ public static IEnumerable<object[]> Hwnd_TestData()
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/22221", TestPlatforms.AnyUnix)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51097", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process), nameof(PlatformDetection.IsWindows10OrLater))]
[ConditionalTheory(Helpers.IsDrawingSupported)]
[MemberData(nameof(Hwnd_TestData))]
public void FromHwnd_ValidHwnd_ReturnsExpected(IntPtr hWnd)
Expand All @@ -270,6 +274,7 @@ public void FromHwnd_ValidHwnd_ReturnsExpected(IntPtr hWnd)
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/22221", TestPlatforms.AnyUnix)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51097", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process), nameof(PlatformDetection.IsWindows10OrLater))]
[ConditionalTheory(Helpers.IsDrawingSupported)]
[MemberData(nameof(Hwnd_TestData))]
public void FromHwndInternal_ValidHwnd_ReturnsExpected(IntPtr hWnd)
Expand Down

0 comments on commit 643ab28

Please sign in to comment.