Add a quirk to avoid diffs on x86

dotnet · Apr 17, 2022 · 6af2d7a · 6af2d7a
1 parent ddce36b
commit 6af2d7a
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/coreclr/jit/gcinfo.cpp b/src/coreclr/jit/gcinfo.cpp
@@ -256,8 +256,16 @@ GCInfo::WriteBarrierForm GCInfo::gcIsWriteBarrierCandidate(GenTreeStoreInd* stor
 
     if (wbf == WBF_BarrierUnknown)
     {
-        assert(store->Addr()->TypeIs(TYP_BYREF));
-        wbf = ((store->gtFlags & GTF_IND_TGT_HEAP) != 0) ? WBF_BarrierUnchecked : WBF_BarrierChecked;
+        if (compiler->codeGen->genUseOptimizedWriteBarriers(wbf))
+        {
+            // TODO-CQ: remove this pessimization, it was added to avoid diffs.
+            wbf = WBF_BarrierChecked;
+        }
+        else
+        {
+            assert(store->Addr()->TypeIs(TYP_BYREF));
+            wbf = ((store->gtFlags & GTF_IND_TGT_HEAP) != 0) ? WBF_BarrierUnchecked : WBF_BarrierChecked;
+        }
     }
 
     return wbf;