Fix bug in EqualsIgnoreCaseUtf8_Scalar (#89174)

dotnet · Jul 19, 2023 · 718f02e · 718f02e
1 parent 7d9f506
commit 718f02e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Globalization/Ordinal.Utf8.cs b/src/libraries/System.Private.CoreLib/src/System/Globalization/Ordinal.Utf8.cs
@@ -296,13 +296,7 @@ internal static bool EqualsIgnoreCaseUtf8_Scalar(ref byte charA, int lengthA, re
                     return true;
                 }
 
-                if (!Utf8Utility.UInt32OrdinalIgnoreCaseAscii(valueAu32, valueBu32))
-                {
-                    return false;
-                }
-
-                byteOffset += 4;
-                length -= 4;
+                return Utf8Utility.UInt32OrdinalIgnoreCaseAscii(valueAu32, valueBu32);
             }
 
             Debug.Assert(length == 0);

diff --git a/src/libraries/System.Text.Json/tests/Common/NumberHandlingTests.cs b/src/libraries/System.Text.Json/tests/Common/NumberHandlingTests.cs
@@ -873,7 +873,6 @@ async Task PerformFloatingPointSerialization(string testString)
         [InlineData("\u0020Inf\u0069ni\u0074y")] // " Infinity"
         [InlineData("\u002BInf\u0069nity")] // "+Infinity"
 #pragma warning restore xUnit1025
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/89094", TestPlatforms.OSX)]
         public async Task FloatingPointConstants_Fail(string testString)
         {
             string testStringAsJson = $@"""{testString}""";