Skip to content

Commit

Permalink
Fix SuperPMI collections (#99867)
Browse files Browse the repository at this point in the history
The `produce_repro` argument needs to be initialized for collections.
  • Loading branch information
BruceForstall committed Mar 16, 2024
1 parent ca48a0d commit 7740dbd
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions src/coreclr/scripts/superpmi.py
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ def run_to_completion(self, async_callback, *extra_args):
loop = asyncio.new_event_loop()

asyncio.set_event_loop(loop)

loop.run_until_complete(self.__run_to_completion__(async_callback, *extra_args))
os.environ.clear()
os.environ.update(reset_env)
Expand Down Expand Up @@ -1867,11 +1867,11 @@ def write_jit_options(coreclr_args, write_fh):
Args:
coreclr_args: args class instance
write_fh: file to output to
"""
base_options = []
diff_options = []

if coreclr_args.jitoption:
base_options += coreclr_args.jitoption
diff_options += coreclr_args.jitoption
Expand Down Expand Up @@ -4500,7 +4500,7 @@ def verify_replay_common_args():
"produce_repro",
lambda unused: True,
"Unable to set produce_repro")

coreclr_args.verify(args,
"private_store",
lambda item: True,
Expand Down Expand Up @@ -4592,6 +4592,11 @@ def verify_base_diff_args():
lambda unused: True,
"Method context not valid")

coreclr_args.verify(args,
"produce_repro", # The replay code checks this, so make sure it's set
lambda unused: True,
"Unable to set produce_repro")

coreclr_args.verify(args,
"collection_command",
lambda unused: True,
Expand Down

0 comments on commit 7740dbd

Please sign in to comment.