Skip to content

Commit

Permalink
Rewrite RegexPrefixAnalyzer.FindFirstCharClass (#67732)
Browse files Browse the repository at this point in the history 
Every other analysis we use is on a recursion plan; this one is the last holdover that's still based on iteration maintaining its own custom stack of objects, making it difficult to comprehend the logic.  As it turns out, it also has some bugs causing it to miss some cases, in particular where the pattern starts with an anchor followed by a negated set.  This PR rewrites it to be simpler / recursive like the rest of our analyses.
  • Loading branch information
@stephentoub
stephentoub committed Apr 9, 2022
1 parent 45cc9d5 commit c38f006
Show file tree
Hide file tree
Showing 3 changed files with 287 additions and 346 deletions.

0 comments on commit c38f006

Please sign in to comment.