Reinstate strict prototypes warning (#76463)

* reinstate strict-prototype warning * More fixes * Need to keep the warning disabled for zlib madler/zlib#633 Co-authored-by: Jan Kotas <jkotas@microsoft.com>
dotnet · Oct 1, 2022 · d320fd9 · d320fd9
1 parent 06ce127
commit d320fd9
Show file tree

Hide file tree

Showing 74 changed files with 190 additions and 191 deletions.
diff --git a/src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.h b/src/coreclr/vm/eventing/eventpipe/ep-rt-coreclr.h
@@ -2065,7 +2065,7 @@ ep_rt_thread_create (
 static
 inline
 void
-ep_rt_set_server_name()
+ep_rt_set_server_name(void)
 {
 	::SetThreadName(GetCurrentThread(), W(".NET EventPipe"));
 }

diff --git a/src/mono/mono/eventpipe/ep-rt-mono.c b/src/mono/mono/eventpipe/ep-rt-mono.c
@@ -2120,13 +2120,13 @@ ep_rt_mono_rand_try_get_bytes (
 }
 
 char *
-ep_rt_mono_get_managed_cmd_line ()
+ep_rt_mono_get_managed_cmd_line (void)
 {
 	return mono_runtime_get_managed_cmd_line ();
 }
 
 char *
-ep_rt_mono_get_os_cmd_line ()
+ep_rt_mono_get_os_cmd_line (void)
 {
 	MONO_REQ_GC_NEUTRAL_MODE;
 
@@ -3084,7 +3084,7 @@ struct _BulkTypeEventLogger {
 
 static
 BulkTypeEventLogger*
-ep_rt_bulk_type_event_logger_alloc ()
+ep_rt_bulk_type_event_logger_alloc (void)
 {
 	BulkTypeEventLogger *type_logger = g_malloc0 (sizeof (BulkTypeEventLogger));
 	type_logger->bulk_type_event_buffer = g_malloc0 (sizeof (uint8_t) * MAX_SIZE_OF_EVENT_BUFFER);

diff --git a/src/mono/mono/eventpipe/ep-rt-mono.h b/src/mono/mono/eventpipe/ep-rt-mono.h
@@ -1362,7 +1362,7 @@ ep_rt_thread_create (
 static
 inline
 void
-ep_rt_set_server_name()
+ep_rt_set_server_name(void)
 {
 	mono_native_thread_set_name(mono_native_thread_id_get(), ".NET EventPipe");
 }
@@ -1963,7 +1963,7 @@ ep_rt_runtime_version_get_utf8 (void)
 static
 inline
 void
-ep_rt_thread_setup ()
+ep_rt_thread_setup (void)
 {
 	ep_rt_mono_thread_setup (false);
 }

diff --git a/src/mono/mono/metadata/appdomain.c b/src/mono/mono/metadata/appdomain.c
@@ -977,7 +977,7 @@ runtimeconfig_json_read_props (const char *ptr, const char **endp, int nprops, g
 }
 
 void
-mono_security_enable_core_clr ()
+mono_security_enable_core_clr (void)
 {
 	// no-op
 }

diff --git a/src/mono/mono/metadata/assembly.c b/src/mono/mono/metadata/assembly.c
@@ -2680,7 +2680,7 @@ mono_assembly_load_with_partial_name_internal (const char *name, MonoAssemblyLoa
 }
 
 MonoAssembly*
-mono_assembly_load_corlib ()
+mono_assembly_load_corlib (void)
 {
 	MonoAssemblyName *aname;
 	MonoAssemblyOpenRequest req;

diff --git a/src/mono/mono/metadata/boehm-gc.c b/src/mono/mono/metadata/boehm-gc.c
@@ -1097,12 +1097,12 @@ mono_gc_set_stack_end (void *stack_end)
 {
 }
 
-void GC_start_blocking ()
+void GC_start_blocking (void)
 {
 
 }
 
-void GC_end_blocking ()
+void GC_end_blocking (void)
 {
 
 }

diff --git a/src/mono/mono/metadata/class-init.c b/src/mono/mono/metadata/class-init.c
@@ -2553,13 +2553,13 @@ initialize_object_slots (MonoClass *klass)
 }
 
 int
-mono_class_get_object_finalize_slot ()
+mono_class_get_object_finalize_slot (void)
 {
 	return finalize_slot;
 }
 
 MonoMethod *
-mono_class_get_default_finalize_method ()
+mono_class_get_default_finalize_method (void)
 {
 	int const i = finalize_slot;
 	return (i < 0) ? NULL : mono_defaults.object_class->vtable [i];

diff --git a/src/mono/mono/metadata/domain.c b/src/mono/mono/metadata/domain.c
@@ -385,7 +385,7 @@ mono_get_root_domain (void)
  * \returns the current domain
  */
 MonoDomain *
-mono_domain_get ()
+mono_domain_get (void)
 {
 	return GET_APPDOMAIN ();
 }

diff --git a/src/mono/mono/metadata/exception.c b/src/mono/mono/metadata/exception.c
@@ -464,7 +464,7 @@ mono_get_exception_serialization (const char *msg)
  * \returns a new instance of the \c System.InvalidCastException
  */
 MonoException *
-mono_get_exception_invalid_cast ()
+mono_get_exception_invalid_cast (void)
 {
 	return mono_exception_from_name (mono_get_corlib (), "System", "InvalidCastException");
 }
@@ -493,7 +493,7 @@ mono_exception_new_invalid_operation (const char *msg, MonoError *error)
  * \returns a new instance of the \c System.IndexOutOfRangeException
  */
 MonoException *
-mono_get_exception_index_out_of_range ()
+mono_get_exception_index_out_of_range (void)
 {
 	return mono_exception_from_name (mono_get_corlib (), "System",
 					 "IndexOutOfRangeException");

diff --git a/src/mono/mono/metadata/loader.c b/src/mono/mono/metadata/loader.c
@@ -79,7 +79,7 @@ static gint32 methods_size;
 static gint32 signatures_size;
 
 void
-mono_loader_init ()
+mono_loader_init (void)
 {
 	static gboolean inited;
 

diff --git a/src/mono/mono/metadata/sgen-mono.c b/src/mono/mono/metadata/sgen-mono.c
@@ -2148,7 +2148,7 @@ mono_gc_set_gc_callbacks (MonoGCCallbacks *callbacks)
 }
 
 MonoGCCallbacks *
-mono_gc_get_gc_callbacks ()
+mono_gc_get_gc_callbacks (void)
 {
 	return &gc_callbacks;
 }

diff --git a/src/mono/mono/metadata/sgen-stw.c b/src/mono/mono/metadata/sgen-stw.c
@@ -44,7 +44,7 @@ static void unified_suspend_stop_world (MonoThreadInfoFlags flags, unified_suspe
 
 static TV_DECLARE (end_of_last_stw);
 
-guint64 mono_time_since_last_stw ()
+guint64 mono_time_since_last_stw (void)
 {
 	if (end_of_last_stw == 0)
 		return 0;

diff --git a/src/mono/mono/mini/exceptions-amd64.c b/src/mono/mono/mini/exceptions-amd64.c
@@ -195,7 +195,7 @@ static LONG CALLBACK seh_vectored_exception_handler(EXCEPTION_POINTERS* ep)
 	return res;
 }
 
-void win32_seh_init()
+void win32_seh_init(void)
 {
 	if (!mono_aot_only)
 		restore_stack = (void (*) (void))get_win32_restore_stack ();
@@ -204,7 +204,7 @@ void win32_seh_init()
 	mono_win_vectored_exception_handle = AddVectoredExceptionHandler (1, seh_vectored_exception_handler);
 }
 
-void win32_seh_cleanup()
+void win32_seh_cleanup(void)
 {
 	guint32 ret = 0;
 

diff --git a/src/mono/mono/mini/exceptions-x86.c b/src/mono/mono/mini/exceptions-x86.c
@@ -243,7 +243,7 @@ static LONG CALLBACK seh_vectored_exception_handler(EXCEPTION_POINTERS* ep)
 	return res;
 }
 
-void win32_seh_init()
+void win32_seh_init(void)
 {
 	/* install restore stack helper */
 	if (!restore_stack)
@@ -253,7 +253,7 @@ void win32_seh_init()
 	mono_win_vectored_exception_handle = AddVectoredExceptionHandler (1, seh_vectored_exception_handler);
 }
 
-void win32_seh_cleanup()
+void win32_seh_cleanup(void)
 {
 	if (mono_old_win_toplevel_exception_filter)
 		SetUnhandledExceptionFilter(mono_old_win_toplevel_exception_filter);

diff --git a/src/mono/mono/mini/jit-icalls.c b/src/mono/mono/mini/jit-icalls.c
@@ -1626,23 +1626,23 @@ mono_throw_method_access (MonoMethod *caller, MonoMethod *callee)
 }
 
 void
-mono_throw_bad_image ()
+mono_throw_bad_image (void)
 {
 	ERROR_DECL (error);
 	mono_error_set_generic_error (error, "System", "BadImageFormatException", "Bad IL format.");
 	mono_error_set_pending_exception (error);
 }
 
 void
-mono_throw_not_supported ()
+mono_throw_not_supported (void)
 {
 	ERROR_DECL (error);
 	mono_error_set_generic_error (error, "System", "NotSupportedException", "");
 	mono_error_set_pending_exception (error);
 }
 
 void
-mono_throw_platform_not_supported ()
+mono_throw_platform_not_supported (void)
 {
 	ERROR_DECL (error);
 	mono_error_set_generic_error (error, "System", "PlatformNotSupportedException", "");

diff --git a/src/mono/mono/mini/llvm-jit.cpp b/src/mono/mono/mini/llvm-jit.cpp
@@ -362,7 +362,7 @@ init_passes_and_options ()
 }
 
 void
-mono_llvm_jit_init ()
+mono_llvm_jit_init (void)
 {
 	if (jit != nullptr) return;
 
@@ -466,7 +466,7 @@ mono_llvm_set_unhandled_exception_handler (void)
 }
 
 void
-mono_llvm_jit_init ()
+mono_llvm_jit_init (void)
 {
 }
 

diff --git a/src/mono/mono/mini/mini-runtime.c b/src/mono/mono/mini/mini-runtime.c
@@ -5206,7 +5206,7 @@ mono_precompile_assembly (MonoAssembly *ass, void *user_data)
 	}
 }
 
-void mono_precompile_assemblies ()
+void mono_precompile_assemblies (void)
 {
 	GHashTable *assemblies = g_hash_table_new (NULL, NULL);
 

diff --git a/src/mono/mono/mini/mini.c b/src/mono/mono/mini/mini.c
@@ -4050,7 +4050,7 @@ mono_cfg_set_exception_invalid_program (MonoCompile *cfg, const char *msg)
 
 #endif /* DISABLE_JIT */
 
-gint64 mono_time_track_start ()
+gint64 mono_time_track_start (void)
 {
 	return mono_100ns_ticks ();
 }

diff --git a/src/mono/mono/mini/trace.c b/src/mono/mono/mini/trace.c
@@ -482,7 +482,7 @@ mono_trace_enable (gboolean enable)
 }
 
 gboolean
-mono_trace_is_enabled ()
+mono_trace_is_enabled (void)
 {
 	return trace_spec.enabled;
 }
diff --git a/src/mono/mono/sgen/sgen-gc.c b/src/mono/mono/sgen/sgen-gc.c
@@ -3920,7 +3920,7 @@ sgen_gc_init (void)
 }
 
 gboolean
-sgen_gc_initialized ()
+sgen_gc_initialized (void)
 {
 	return gc_initialized > 0;
 }

diff --git a/src/mono/mono/utils/mach-support-amd64.c b/src/mono/mono/utils/mach-support-amd64.c
@@ -23,7 +23,7 @@
 #include <mono/arch/amd64/amd64-codegen.h>
 
 int
-mono_mach_arch_get_mcontext_size ()
+mono_mach_arch_get_mcontext_size (void)
 {
 	return sizeof (struct __darwin_mcontext64);
 }
@@ -89,13 +89,13 @@ mono_mach_arch_thread_states_to_mono_context (thread_state_t state, thread_state
 }
 
 int
-mono_mach_arch_get_thread_state_size ()
+mono_mach_arch_get_thread_state_size (void)
 {
 	return sizeof (x86_thread_state64_t);
 }
 
 int
-mono_mach_arch_get_thread_fpstate_size ()
+mono_mach_arch_get_thread_fpstate_size (void)
 {
 	return sizeof (x86_float_state64_t);
 }

diff --git a/src/mono/mono/utils/mach-support-arm.c b/src/mono/mono/utils/mach-support-arm.c
@@ -26,7 +26,7 @@
 #endif
 
 int
-mono_mach_arch_get_mcontext_size ()
+mono_mach_arch_get_mcontext_size (void)
 {
 	return sizeof (struct __darwin_mcontext);
 }
@@ -64,13 +64,13 @@ mono_mach_arch_thread_states_to_mono_context (thread_state_t state, thread_state
 }
 
 int
-mono_mach_arch_get_thread_state_size ()
+mono_mach_arch_get_thread_state_size (void)
 {
 	return sizeof (arm_thread_state_t);
 }
 
 int
-mono_mach_arch_get_thread_fpstate_size ()
+mono_mach_arch_get_thread_fpstate_size (void)
 {
 	return sizeof (arm_neon_state_t);
 }

diff --git a/src/mono/mono/utils/mach-support-arm64.c b/src/mono/mono/utils/mach-support-arm64.c
@@ -26,7 +26,7 @@
 #endif
 
 int
-mono_mach_arch_get_mcontext_size ()
+mono_mach_arch_get_mcontext_size (void)
 {
 	return sizeof (struct __darwin_mcontext64);
 }
@@ -81,13 +81,13 @@ mono_mach_arch_thread_states_to_mono_context (thread_state_t state, thread_state
 }
 
 int
-mono_mach_arch_get_thread_state_size ()
+mono_mach_arch_get_thread_state_size (void)
 {
 	return sizeof (arm_unified_thread_state_t);
 }
 
 int
-mono_mach_arch_get_thread_fpstate_size ()
+mono_mach_arch_get_thread_fpstate_size (void)
 {
 	return sizeof (arm_neon_state64_t);
 }

diff --git a/src/mono/mono/utils/mach-support-unknown.c b/src/mono/mono/utils/mach-support-unknown.c
@@ -18,7 +18,7 @@
 #include "mach-support.h"
 
 int
-mono_mach_arch_get_mcontext_size ()
+mono_mach_arch_get_mcontext_size (void)
 {
 	g_assert_not_reached ();
 }
@@ -42,13 +42,13 @@ mono_mach_arch_thread_states_to_mono_context (thread_state_t state, thread_state
 }
 
 int
-mono_mach_arch_get_thread_state_size ()
+mono_mach_arch_get_thread_state_size (void)
 {
 	g_assert_not_reached ();
 }
 
 int
-mono_mach_arch_get_thread_fpstate_size ()
+mono_mach_arch_get_thread_fpstate_size (void)
 {
 	g_assert_not_reached ();
 }

diff --git a/src/mono/mono/utils/mach-support-x86.c b/src/mono/mono/utils/mach-support-x86.c
@@ -21,7 +21,7 @@
 #include <mono/arch/amd64/amd64-codegen.h>
 
 int
-mono_mach_arch_get_mcontext_size ()
+mono_mach_arch_get_mcontext_size (void)
 {
 	return sizeof (struct __darwin_mcontext32);
 }
@@ -71,13 +71,13 @@ mono_mach_arch_thread_states_to_mono_context (thread_state_t state, thread_state
 }
 
 int
-mono_mach_arch_get_thread_state_size ()
+mono_mach_arch_get_thread_state_size (void)
 {
 	return sizeof (x86_thread_state32_t);
 }
 
 int
-mono_mach_arch_get_thread_fpstate_size ()
+mono_mach_arch_get_thread_fpstate_size (void)
 {
 	return sizeof (x86_float_state32_t);
 }