Skip to content

Commit

Permalink
Globally disable Windows ARM32 runs to reduce noise in CoreCLR runs (#…
Browse files Browse the repository at this point in the history
…1687)

As we still don't have a final resolution w.r.t. a new Windows
queue to run ARM32 tests on, I propose globally disable them before
the issue is resolved. We're tracking the underlying problem in:

#1097
#1663
dotnet/core-eng#8490

Thanks

Tomas
  • Loading branch information
trylek committed Jan 14, 2020
1 parent 0812d49 commit f7d2dbd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
1 change: 0 additions & 1 deletion eng/pipelines/common/platform-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,6 @@ jobs:
${{ insert }}: ${{ parameters.jobParameters }}

# Windows arm

- ${{ if or(containsValue(parameters.platforms, 'Windows_NT_arm'), eq(parameters.platformGroup, 'all')) }}:
- template: xplat-setup.yml
parameters:
Expand Down
12 changes: 8 additions & 4 deletions eng/pipelines/coreclr/templates/helix-queues-setup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,14 @@ jobs:

# Windows_NT arm
- ${{ if eq(parameters.platform, 'Windows_NT_arm') }}:
- ${{ if and(eq(variables['System.TeamProject'], 'public'), in(parameters.jobParameters.helixQueueGroup, 'pr', 'ci', 'corefx')) }}:
- Windows.10.Arm64.Open
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- Windows.10.Arm64
# Currently down as there's no suitable ARM32 pool at the moment, tracked under
# https://github.com/dotnet/runtime/issues/1097
# https://github.com/dotnet/runtime/issues/1663
# https://github.com/dotnet/core-eng/issues/8490
# - ${{ if and(eq(variables['System.TeamProject'], 'public'), in(parameters.jobParameters.helixQueueGroup, 'pr', 'ci', 'corefx')) }}:
# - Windows.10.Arm64.Open
- ${{ if eq(variables['System.TeamProject'], 'internal') }}:
- Windows.10.Arm64

# Windows_NT arm64
- ${{ if eq(parameters.platform, 'Windows_NT_arm64') }}:
Expand Down

0 comments on commit f7d2dbd

Please sign in to comment.