Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workloads] add wbt that checks downlevel runtime versions. #101809

Open
lewing opened this issue May 2, 2024 · 3 comments · May be fixed by #102190
Open

[workloads] add wbt that checks downlevel runtime versions. #101809

lewing opened this issue May 2, 2024 · 3 comments · May be fixed by #102190
Assignees
Labels
area-Workloads Workloads like wasm-tools
Milestone

Comments

@lewing
Copy link
Member

lewing commented May 2, 2024

We should add a wbt that checks the workload downlevel runtime versions against the new installer and fails if they are lower than the properties in eng/Versions.props

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 2, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 2, 2024
@lewing lewing added area-Workloads Workloads like wasm-tools and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 2, 2024
@lewing lewing added this to the 9.0.0 milestone May 2, 2024
@lewing
Copy link
Member Author

lewing commented May 2, 2024

This will help but it will still be quite fragile because installer often doesn't update the downlevel versions until after we should have already changed ours. We'll also need to do the same in emsdk to make sure that VS insertions go smoothly and we don't have the installer flow setup there (although we could add it)

cc @marcpopMSFT @joeloff

@marcpopMSFT
Copy link
Member

If you're going off of the implicit version, I'm not sure this will work. Typically in VS main we'll have a .net preview that has N-1 implicit versions but N workloads. This is because VS added a package verification check that flags our workloads in main being behind their release branches. This check doesn't flag our implicit version/runtime.

@lewing
Copy link
Member Author

lewing commented May 3, 2024

Yeah, we could do implicit+1 on preview branches😉. We need to know ahead of time the versions that will be inserted into VS for a given branch so I guess we need a mechanism that will allow that or we need to produce the downlevel manifests somewhere other than runtime.

@maraf maraf linked a pull request May 14, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Workloads Workloads like wasm-tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants