Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-preview4] Bump downlevel runtime produced package versions in the workload manifest #101807

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 2, 2024

Backport of #101806 to release/9.0-preview4 opened to track resolving this for the future #101809

/cc @lewing

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 2, 2024
@lewing lewing added Servicing-consider Issue for next servicing release review area-Infrastructure-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 2, 2024
Copy link
Contributor

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

@lewing lewing requested review from akoeplinger and maraf May 2, 2024 16:45
@lewing lewing added area-Workloads Workloads like wasm-tools and removed area-Infrastructure-mono labels May 2, 2024
@lewing lewing requested a review from thaystg May 2, 2024 16:47
@jeffschwMSFT jeffschwMSFT removed the Servicing-consider Issue for next servicing release review label May 2, 2024
@lewing lewing added the Servicing-consider Issue for next servicing release review label May 2, 2024
@jeffschwMSFT
Copy link
Member

the window for a preview 4 change has come and gone. how critical is this change?

@lewing lewing removed the Servicing-consider Issue for next servicing release review label May 2, 2024
@lewing
Copy link
Member

lewing commented May 2, 2024

the window for a preview 4 change has come and gone. how critical is this change?

I was going to discuss it at tactics, it blocks the new debugger when targeting net8 https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2046430

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label May 2, 2024
@jeffschwMSFT jeffschwMSFT added this to the 8.0.x milestone May 2, 2024
@lewing lewing requested a review from marcpopMSFT May 2, 2024 17:02
@lewing lewing changed the title [release/9.0-preview4] Bump downlevel [release/9.0-preview4] Bump downlevel runtime produces package versions in the workload manifest May 2, 2024
@lewing
Copy link
Member

lewing commented May 2, 2024

The plan is to get a testable sdk build then if there is enough time merge this and fast track it.

@lewing lewing changed the title [release/9.0-preview4] Bump downlevel runtime produces package versions in the workload manifest [release/9.0-preview4] Bump downlevel runtime produced package versions in the workload manifest May 2, 2024
@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 2, 2024
@lewing
Copy link
Member

lewing commented May 2, 2024

/ba-g failures are known and fixed in main

@lewing lewing merged commit 77d2b8d into release/9.0-preview4 May 2, 2024
154 of 177 checks passed
@lewing lewing deleted the backport/pr-101806-to-release/9.0-preview4 branch May 2, 2024 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Workloads Workloads like wasm-tools Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants