[release/8.0] Use V5 ESRP task with backing MI + AKV #102582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
thaystg
approved these changes
May 23, 2024
| @@ -48,6 +53,7 @@ steps: | |||
| SessionTimeout: ${{ parameters.timeoutInMinutes }} | |||
| MaxConcurrency: '50' | |||
| MaxRetryAttempts: '5' | |||
| PendingAnalysisWaitTimeoutMinutes: '5' | |||
There was a problem hiding this comment.
Did you choose this time from experience?
There was a problem hiding this comment.
Just defaults that have been used in main for a while.
jeffschwMSFT
approved these changes
May 23, 2024
hoyosjs
added
Servicing-approved
|
Tagging subscribers to this area: @hoyosjs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main PR: #102542
Description
This PR moves to using WIF + AKV RBAC to support signing diagnostic files without need of manual cert or secret rotation.
Customer Impact
None. Infra change
Regression
None
Testing
Internal test build.
Risk
Low, expansion reqs not changes and same template has signing validation script.