Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Use V5 ESRP task with backing MI + AKV #102582

Merged
merged 1 commit into from
May 24, 2024
Merged

[release/8.0] Use V5 ESRP task with backing MI + AKV #102582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions eng/pipelines/coreclr/templates/sign-diagnostic-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,15 @@ steps:
version: '6.0.x'
installationPath: '$(Agent.TempDirectory)/dotnet'

- task: EsrpCodeSigning@1
- task: EsrpCodeSigning@5
displayName: Sign Diagnostic Binaries
inputs:
ConnectedServiceName: 'dotnetesrp-diagnostics-dnceng'
ConnectedServiceName: 'diagnostics-esrp-kvcertuser'
AppRegistrationClientId: '2234cdec-a13f-4bb2-aa63-04c57fd7a1f9'
AppRegistrationTenantId: '72f988bf-86f1-41af-91ab-2d7cd011db47'
AuthAKVName: 'clrdiag-esrp-id'
AuthCertName: 'dotnetesrp-diagnostics-aad-ssl-cert'
AuthSignCertName: 'dotnet-diagnostics-esrp-pki-onecert'
FolderPath: ${{ parameters.basePath }}
Pattern: |
**/mscordaccore*.dll
Expand Down Expand Up @@ -48,6 +53,7 @@ steps:
SessionTimeout: ${{ parameters.timeoutInMinutes }}
MaxConcurrency: '50'
MaxRetryAttempts: '5'
PendingAnalysisWaitTimeoutMinutes: '5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you choose this time from experience?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just defaults that have been used in main for a while.

env:
DOTNET_MULTILEVEL_LOOKUP: 0
DOTNET_ROOT: '$(Agent.TempDirectory)/dotnet'
Expand Down
Loading