Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP/3 APIs #1293

Closed
scalablecory opened this issue Jan 4, 2020 · 3 comments · Fixed by #56775
Closed

Add HTTP/3 APIs #1293

scalablecory opened this issue Jan 4, 2020 · 3 comments · Fixed by #56775
Labels
api-approved API was approved in API review, it can be implemented area-System.Net.Http help wanted [up-for-grabs] Good issue for external contributors
Projects
Milestone

Comments

@scalablecory
Copy link
Contributor

scalablecory commented Jan 4, 2020

This adds APIs needed for HTTP/3.

struct System.Net.Security.SslApplicationProtocol
{
	public static readonly System.Net.Security.SslApplicationProtocol Http3;

	// Existing
	// public static readonly System.Net.Security.SslApplicationProtocol Http2;
	// public static readonly System.Net.Security.SslApplicationProtocol Http11;
}

class System.Net.HttpVersion
{
	public static readonly System.Version Version30;

	// Existing
	// public static readonly System.Version Version20;
	// public static readonly System.Version Version11;
	// public static readonly System.Version Version10;
}
@scalablecory scalablecory added api-suggestion Early API idea and discussion, it is NOT ready for implementation area-System.Net labels Jan 4, 2020
@scalablecory scalablecory self-assigned this Jan 4, 2020
@scalablecory scalablecory added this to To Do in HTTP/3 via automation Jan 4, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 4, 2020
@scalablecory scalablecory added api-ready-for-review and removed api-suggestion Early API idea and discussion, it is NOT ready for implementation labels Jan 5, 2020
@karelz karelz added this to the Future milestone Feb 21, 2020
@karelz karelz added api-suggestion Early API idea and discussion, it is NOT ready for implementation and removed untriaged New issue has not been triaged by the area owner api-ready-for-review labels Feb 21, 2020
@karelz
Copy link
Member

karelz commented Feb 21, 2020

Triage: We need to wait for QUIC spec to be finalized (its ALPN value).

@karelz karelz added blocked Issue/PR is blocked on something - see comments area-System.Net.Http and removed area-System.Net labels Feb 21, 2020
@geoffkizer geoffkizer added api-ready-for-review API is ready for review, it is NOT ready for implementation and removed api-suggestion Early API idea and discussion, it is NOT ready for implementation blocked Issue/PR is blocked on something - see comments labels Oct 13, 2020
@geoffkizer
Copy link
Contributor

Spec is essentially done at this point, let's get these approved and implemented.

@terrajobst terrajobst added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for review, it is NOT ready for implementation labels Oct 27, 2020
@terrajobst
Copy link
Member

terrajobst commented Oct 27, 2020

Video

  • Looks good as proposed
namespace System.Net
{
    public class partial HttpVersion
    {
        // Existing
        // public static readonly Version Version10;
        // public static readonly Version Version11;
        // public static readonly Version Version20;
        public static readonly Version Version30;
    }
}
namespace System.Net.Security
{
    public partial struct SslApplicationProtocol
    {
        // Existing
        // public static readonly SslApplicationProtocol Http11;
        // public static readonly SslApplicationProtocol Http2;
        public static readonly SslApplicationProtocol Http3;
    }
}

@ManickaP ManickaP moved this from To Do (Low Priority) to To Do (High Priority) in HTTP/3 Apr 15, 2021
@karelz karelz added the help wanted [up-for-grabs] Good issue for external contributors label Apr 15, 2021
@karelz karelz moved this from To Do (High Priority) to To Do (Low Priority) in HTTP/3 Apr 15, 2021
@karelz karelz moved this from To Do (Low Priority) to Future in HTTP/3 May 18, 2021
i3arnon added a commit to i3arnon/runtime that referenced this issue Aug 3, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 3, 2021
HTTP/3 automation moved this from Future to Done Aug 4, 2021
ManickaP pushed a commit that referenced this issue Aug 4, 2021
* Add SslApplicationProtocol.Http3

Fix #1293

* Add XML doc

* Reuse in Http3Connection

* Reuse in tests

* HTTP/3 has no negotiation

* Use SslApplicationProtocol.Http3.ToString() in tests

* Ascending order in ref
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 4, 2021
@karelz karelz modified the milestones: Future, 6.0.0 Aug 17, 2021
@dotnet dotnet locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-approved API was approved in API review, it can be implemented area-System.Net.Http help wanted [up-for-grabs] Good issue for external contributors
Projects
No open projects
HTTP/3
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants