Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor System.Linq #14352

Closed
rafidka opened this issue Mar 16, 2015 · 4 comments
Closed

Refactor System.Linq #14352

rafidka opened this issue Mar 16, 2015 · 4 comments
Labels
area-System.Linq
Milestone
1.0.0-rtm

Comments

@rafidka
Copy link
Contributor

rafidka commented Mar 16, 2015

Following @stephentoub comment here:

https://github.com/dotnet/corefx/issues/1143#issuecomment-81683842

I am filing this issue to track doing some refactoring in System.Linq. Currently, everything is in one file which has about 3.2k lines and around 20 classes and interfaces. It is good if this can be refactored to make the code easier to follow.
@ellismg
Copy link
Contributor

ellismg commented Mar 16, 2015

Did you want to do this as part of your work on increasing code coverage?

@rafidka
Copy link
Contributor Author

rafidka commented Mar 16, 2015

Yes, sure, I would love to. It is just that I am not a contributor yet (I hope you make me one), so I can't assign tasks to myself.

@ellismg
Copy link
Contributor

ellismg commented Mar 16, 2015

@rafidka Thanks! I marked the is "grabbed by community" since you're going to take care of it. Please let me know if you change your mind.

@ellismg ellismg self-assigned this Mar 17, 2015
@rafidka
Copy link
Contributor Author

rafidka commented Mar 18, 2015

@stephentoub, just wanted to give you my opinion on this task. Mainly, I want to move classes to their own files rather than everything in one big file which makes it hard to follow. I don't see this breaking anything, and additionally, if we add the unit tests first, then we can be confident about this refactoring.

@joshfree joshfree assigned VSadov and unassigned ellismg Oct 12, 2015
JonHanna referenced this issue in JonHanna/corefx Feb 10, 2016
@JonHanna
Refactor System.Linq
7db7832 
Move classes into separate files.

Split Enumerable among several files.

Remove redundant references to generic types or namespaces.

Fixes #1149
JonHanna referenced this issue in JonHanna/corefx Feb 10, 2016
@JonHanna
Refactor System.Linq
b6a638b 
Move classes into separate files.

Split Enumerable among several files.

Remove redundant references to generic types or namespaces.

Fixes #1149
JonHanna referenced this issue in JonHanna/corefx Feb 11, 2016
@JonHanna
Refactor System.Linq
d242474 
Move classes into separate files.

Split Enumerable among several files.

Remove redundant references to generic types or namespaces.

Fixes #1149
@karelz karelz assigned karelz and unassigned VSadov Oct 3, 2016
@karelz karelz assigned JonHanna and unassigned karelz Oct 18, 2016
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rtm milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Linq
Projects
None yet
Milestone
1.0.0-rtm
Development

No branches or pull requests
6 participants
@rafidka @JonHanna @karelz @VSadov @msftgits @ellismg