Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ValueTuple* binary serializable #19939

Closed
terrajobst opened this issue Jan 17, 2017 · 6 comments
Closed

Make ValueTuple* binary serializable #19939

terrajobst opened this issue Jan 17, 2017 · 6 comments
Assignees
Labels
api-approved API was approved in API review, it can be implemented area-System.Runtime
Milestone

Comments

@terrajobst
Copy link
Member

We generally don’t want to add more types to be binary serializable in the framework, due to complexities and the fragility that it causes across version boundaries (remember that binary serialization has to be backward- and forward compatible). That being said, for ValueTuple we can likely convince ourselves that the serialization behavior is fixed and mostly a function of the types you instantiate the tuple with. It seems a resonable assumption to say that ValueTuple<T1, ..., TN> to be serializable if T1-TN are serializable.

Not being binary serializable also makes it harder (and more fragile) for existing code to switch from Tuple to ValueTuple.

@tarekgh
Copy link
Member

tarekgh commented Jan 17, 2017

CC @jcouv

@jcouv jcouv changed the title Make ValueTupe* binary serilizable Make ValueTuple* binary serializable Jan 17, 2017
@karelz
Copy link
Member

karelz commented Jan 24, 2017

API review: Approved.

@karelz
Copy link
Member

karelz commented Jan 24, 2017

@jcouv can you please do it? We need to change also Desktop.

@jcouv
Copy link
Member

jcouv commented Jan 24, 2017

@karelz I'll stop by your office tomorrow to discuss and confirm.

@karelz
Copy link
Member

karelz commented Jan 25, 2017

@terrajobst will know more. I was just typing without too much context :)
But feel free to stop by and say hi ;-)

@jcouv
Copy link
Member

jcouv commented Feb 5, 2017

Fixed in desktop, coreclr and corert. I think mono will pick this up automatically.
FYI @marek-safar just in case.

@jcouv jcouv closed this as completed Feb 5, 2017
@jcouv jcouv self-assigned this Feb 5, 2017
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-approved API was approved in API review, it can be implemented area-System.Runtime
Projects
None yet
Development

No branches or pull requests

5 participants