-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUIC] Finalize QUIC stream abort model #32075
Labels
area-System.Net.Quic
enhancement
Product code improvement that does NOT require public API changes/additions
Milestone
Comments
Dotnet-GitSync-Bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Feb 10, 2020
scalablecory
removed
the
untriaged
New issue has not been triaged by the area owner
label
Feb 10, 2020
karelz
added
the
enhancement
Product code improvement that does NOT require public API changes/additions
label
Feb 20, 2020
karelz
changed the title
[QUIC]Finalize QUIC abort model
[QUIC] Finalize QUIC abort model
Mar 11, 2020
Isn't this captured already by #756? What's not captured there? |
28 tasks
Should we close this as a dupe of #756? |
I believe we wanted to split #756 into several issues instead #756 (comment) |
Triage: we think the abort APIs will look like this: class QuicStream
{
// abortive -- causing any unsent data to be discarded.
// one direction can be aborted while leaving the other direction open.
// should cause any outstanding ops to throw StreamAbortedException.
public void Abort(long errorCode, QuicAbortDirection direction = QuicAbortDirection.Both);
}
[Flags]
enum QuicAbortDirection
{
Read = 1,
Write = 2,
Both = 3
} |
scalablecory
changed the title
[QUIC] Finalize QUIC abort model
[QUIC] Finalize QUIC stream abort model
Apr 22, 2021
Closed
Coverd by #756 |
ghost
locked as resolved and limited conversation to collaborators
Aug 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Net.Quic
enhancement
Product code improvement that does NOT require public API changes/additions
QUIC supports aborting the read or write side of a stream independently from the other side of the stream.
We should determine how to allow a user to do an "abortive dispose" such that all pending I/Os in both directions are aborted.
runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs
Lines 313 to 315 in 65587ba
runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/MsQuicStream.cs
Lines 364 to 381 in 65587ba
The text was updated successfully, but these errors were encountered: