Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable Warnings 4302, 4311, 4312, and 4377 in CoreCLR #33743

Closed
ivdiazsa opened this issue Mar 19, 2020 · 0 comments · Fixed by #34659
Closed

Reenable Warnings 4302, 4311, 4312, and 4377 in CoreCLR #33743

ivdiazsa opened this issue Mar 19, 2020 · 0 comments · Fixed by #34659
Assignees
@ivdiazsa
Labels
area-Infrastructure-coreclr

Comments

@ivdiazsa
Copy link
Member

The warnings labelled with the following id's are currently disabled due to them causing build errors in CoreCLR:

  • 4302
  • 4311
  • 4312
  • 4477

The problems these warnings show are actually worth looking, as the code they point to might potentially cause issues in the future. Once the fixes are in place, it's worth it to reenable them to ensure even better code quality in future CoreCLR development.
@ivdiazsa ivdiazsa self-assigned this Mar 19, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Mar 19, 2020
@ivdiazsa ivdiazsa removed the untriaged New issue has not been triaged by the area owner label Mar 19, 2020
@ivdiazsa ivdiazsa mentioned this issue Mar 21, 2020
Closed
@ivdiazsa ivdiazsa mentioned this issue Apr 7, 2020
Merged
Infrastructure Backlog CoreClr automation moved this from In progress to Done Apr 9, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ivdiazsa ivdiazsa

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reenable some disabled warnings in CoreCLR
2 participants
@Dotnet-GitSync-Bot @ivdiazsa