Fixed code to reenable some warnings in CoreCLR #33902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvorli
approved these changes
Mar 21, 2020
src/coreclr/src/inc/holder.h
Outdated
| @@ -608,7 +608,7 @@ class BaseWrapper : public BaseHolder<TYPE, BASE, DEFAULTVALUE, IS_NULL> | |||
| { | |||
| return !!(this->m_value != TYPE(value)); | |||
| } | |||
| #ifdef __GNUC__ | |||
|
|
|||
| // This handles the NULL value that is an int and clang | |||
There was a problem hiding this comment.
A nit - the comment talks about clang, but it should be changed to "the compiler"
|
Could you please resolve the merge conflicts? |
Done! Now, I'm just waiting for the checks done in Azure Pipelines to merge. |
|
Issues found in Windows-x86 and Linux-x64 builds. Currently investigating them. Also will run builds for the ARM32 and ARM64 architectures to find any hidden issues, and ensure they work correctly as well. |
- add debug information for `Assert` failures in `MaximumOSVersionTest` - update src/TestingUtils/Microsoft.AspNetCore.Testing/test/MaximumOSVersionTest.cs - co-Authored-By: @Tratcher - try with VS2019 queues - skip `MaximumOSVersion` tests on .NET due to xunit issue - co-authored-by: @Tratcher Commit migrated from dotnet/extensions@26ff835
* Remove Serilog dependency in extensions * Add xunit logging for shutdown tests * Need to remove dependency on AspNetCore.Testing and remove DumpCollector Commit migrated from dotnet/extensions@540b4e8
Commit migrated from dotnet/extensions@6171c14
…x-logging-event-source Fix LoggingEventSource to handle null strings Commit migrated from dotnet/extensions@8d0fa05
Commit migrated from dotnet/extensions@5bcbaa2
…dotnet/extensions#2940) * Add environment var to allow disabling live reload in default builder * Switch to using hostingContext, rename flag to fit nomenclature. * Change flag to memory data source. Change content root default instead of runtime default. * Update config key to be hierarchical. Change await on positive case to be longer and cancel using the reload token. * Uncomment a development test case. * Apply suggestions from code review Co-authored-by: Chris Ross <Tratcher@Outlook.com> Commit migrated from dotnet/extensions@64140f9
…y with mono_gchandle_new_weakref_internal. (#34153) Looks like this was missed in: Unity-Technologies/mono@941a335 Co-authored-by: UnityAlex <UnityAlex@users.noreply.github.com>
Because the formerly uninitialized scratch context is now an input.
Co-authored-by: BrzVlad <BrzVlad@users.noreply.github.com>
Keeping the download of corelib artifacts to check if just corelib is sufficient to build libraires.
…34201) * Unwrap the TargetInvocationException thrown during an IDispatch. This matches the behavior of .NET Framework.
* Add notifyInstructionSetUsage api to jit interface- Add api to be used when the jit is to notify the VM of any usage of higher level instruction sets- Note that this change does nothing using the api. This is merely a scaffolding change to prepare for functional changes later - There is also scaffoling in the jit to JITDUMP any usage of the api * Code review feedback
Revert the warn as error as it's causing the coreclr outerloop build to break. Investigated fixing the warnings but there are a mix of C# and IL warnings. The latter I'm less sure of the fix. Reverting to unblock and will investigate the warnings in parallel. closes #34220
ivdiazsa
requested review from
ahsonkhan,
akoeplinger,
alexischr,
BrzVlad,
CoffeeFlux,
EgorBo,
imhameed,
Jozkee,
lambdageek,
lateralusX,
layomia,
lewurm,
marek-safar,
naricc,
SamMonoRT,
steveharter,
steveisok,
thaystg and
vargaz
as code owners
|
Please ignore the commits not made by me. Those are already in |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some necessary casts and fixed string formats to comply with warnings 4302, 4311, 4312, and 4477 in CoreCLR. Having these warnings back on will help improve code quality and reduce potential scenarios where unpredicted behavior might cause further issues.