Skipping Json StreamTests.HandleCollectionsAsync test

[steveisok]

This test fails as a long running test and will be skipped. This issue exists to make sure we address it moving forward.

[ghost]

Tagging subscribers to this area: @jozkee
Notify danmosemsft if you want to be subscribed.

[layomia]

Will be disabled in #35568.

[ViktorHofer]

This test is also long running on Mono non interpreter: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-37652-merge-361a17c89eb64365a4/System.Text.Json.Tests/console.491a3b1e.log?sv=2019-07-07&se=2020-10-20T10:59:13Z&sr=c&sp=rl&sig=prSLivaRakBMV01DvMn9azNjasMepSC/ri5n5mgdQM8=.

https://dev.azure.com/dnceng/public/_build/results?buildId=836657&view=ms.vss-test-web.build-test-results-tab&runId=26654654&resultId=176610&paneView=attachments

[ViktorHofer]

Hanging again this time on CoreCLR: https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-43185-merge-1b23d2c75eb24a8891/System.Text.Json.Tests/console.cb4a64bf.log?sv=2019-07-07&se=2020-10-30T02%3A28%3A54Z&sr=c&sp=rl&sig=aoJRcu35I697idbF6olx02wDyhDhgUZE7gRU85kvQlQ%3D

   System.Text.Json.Tests: [Long Running Test] 'System.Text.Json.Serialization.Tests.ConstructorTests_String.Cannot_DeserializeAsync_ObjectWith_Ctor_With_65_Params', Elapsed: 00:03:23
[Long Running Test] 'System.Text.Json.Serialization.Tests.StreamTests.HandleCollectionsAsync', Elapsed: 00:02:03
[Long Running Test] 'System.Text.Json.Tests.JsonDocumentTests.ParseJson_UnseekableStream_Async_BadBOM', Elapsed: 00:11:44
[Long Running Test] 'System.Text.Json.Serialization.Tests.ConstructorTests_Stream.MultipleTypes', Elapsed: 00:11:39
[Long Running Test] 'System.Text.Json.Serialization.Tests.CacheTests.MultipleTypes', Elapsed: 00:07:52
[Long Running Test] 'System.Text.Json.Tests.Utf8JsonWriterTests.Writing3MBBase64Bytes', Elapsed: 00:03:28

[safern]

I created an issue for the CoreCLR checked hangs as it is happening pretty often, it needs attention and there are more tests than just HandleCollectionsAsync: #45464

[eiriktsarpalis]

The test starting hanging in net461 debug test runs, curiously after dfd618d got merged. We might consider either refactoring the test or disabling it for net461 as well. cc @layomia @stephentoub @ericstj

[stephentoub]

curiously after dfd618d got merged

It's because System.Text.Json apparently reaches into Corelib's directory to include:
https://github.com/dotnet/runtime/blob/e0024e22c7761cbbdd10a845f8b0269ea654cbfc/src/libraries/System.Private.CoreLib/src/System/Text/UnicodeDebug.cs

When compiled for .NET 6, where we have the new interpolated string handler for Debug.Assert, this:

runtime/src/libraries/System.Private.CoreLib/src/System/Text/UnicodeDebug.cs

Line 55 in e0024e2

private static string ToHexString(uint codePoint) => $"U+{codePoint:X4}";

will only ever be executed when an assert fails.

But pre-.NET 6, the Debug.Assert message strings that access that ToHexString method will invoke it for every assert, whether it passes or fails.

[steveharter]

@eiriktsarpalis can this be closed? It appears UnicodeDebug.cs was reverted in #55954

[eiriktsarpalis]

#55954 addressed a performance regression that made net461 runs time out, however this particular test is known to time out in other platforms even before that regression got introduced.

We should keep this open for now, @steveisok is it ok if we remove this from 6.0.0 milestone?

[steveisok]

Yes, that is fine to remove the 6 milestone.