Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetRequiredCustomModifiers on DynamicMethod parameter on mono throws NotSupportedException #36271

Closed
stephentoub opened this issue May 12, 2020 · 1 comment · Fixed by #38646 or mono/mono#20052
Closed

GetRequiredCustomModifiers on DynamicMethod parameter on mono throws NotSupportedException #36271

stephentoub opened this issue May 12, 2020 · 1 comment · Fixed by #38646 or mono/mono#20052
Assignees
@alexischr
Labels
area-System.Reflection.Emit runtime-mono specific to the Mono runtime
Milestone
5.0.0

Comments

@stephentoub
Copy link
Member 

      System.NotSupportedException : Custom modifiers on a ParamInfo with member System.Reflection.Emit.DynamicMethod are not supported
      Stack Trace:
        /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeParameterInfo.cs(322,0): at System.Reflection.RuntimeParameterInfo.GetCustomModifiers(Boolean optional)
        /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeParameterInfo.cs(287,0): at System.Reflection.RuntimeParameterInfo.GetRequiredCustomModifiers()
        /_/src/libraries/System.Reflection.Emit.Lightweight/tests/DynamicMethodDefineParameter.cs(47,0): at System.Reflection.Emit.Tests.DynamicMethodDefineParameter.DefineParameter_SetsParameterCorrectly()
        /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(359,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label May 12, 2020
@jkotas jkotas added runtime-mono specific to the Mono runtime and removed area-CoreLib-mono labels May 12, 2020
@lambdageek lambdageek removed the untriaged New issue has not been triaged by the area owner label Jun 22, 2020
@lambdageek lambdageek added this to the 5.0.0 milestone Jun 22, 2020
@lambdageek
Copy link
Member

/cc @SamMonoRT

alexischr added a commit to alexischr/runtime that referenced this issue Jun 30, 2020
@alexischr
[mono] Implement getting the type modifiers for DynamicMethod parameters
d6288b4 
Fixes dotnet#36271
@alexischr alexischr mentioned this issue Jun 30, 2020
Merged
@monojenkins monojenkins mentioned this issue Jun 30, 2020
Merged
monojenkins pushed a commit to monojenkins/mono that referenced this issue Jul 1, 2020
@alexischr
[mono] Implement getting the type modifiers for DynamicMethod parameters
02b6b8f 
Fixes dotnet/runtime#36271
alexischr added a commit that referenced this issue Jul 1, 2020
@alexischr
[mono] Implement getting the type modifiers for DynamicMethod paramet…
bbc9a56 
…ers (#38646)

* [mono] Implement getting the type modifiers for DynamicMethod parameters

Fixes #36271

* Remove unused parameter from type_array_from_modifiers()
alexischr added a commit to mono/mono that referenced this issue Jul 1, 2020
@monojenkins @alexischr
[mono] Implement getting the type modifiers for DynamicMethod paramet…
7930204 
…ers (#20052)

Fixes dotnet/runtime#36271

Co-authored-by: alexischr <alexischr@users.noreply.github.com>
kevinwkt pushed a commit to kevinwkt/runtimelab that referenced this issue Jul 15, 2020
@alexischr @kevinwkt
[mono] Implement getting the type modifiers for DynamicMethod paramet…
ccbf3ca 
…ers (#38646)

* [mono] Implement getting the type modifiers for DynamicMethod parameters

Fixes dotnet/runtime#36271

* Remove unused parameter from type_array_from_modifiers()
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexischr alexischr

Labels
area-System.Reflection.Emit runtime-mono specific to the Mono runtime
Projects
None yet
Milestone
5.0.0
5 participants
@lambdageek @alexischr @stephentoub @jkotas @Dotnet-GitSync-Bot