Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation tests to verify linker annotation and XML descriptor changes #37677

Closed
7 tasks done
layomia opened this issue Jun 9, 2020 · 3 comments
Closed
7 tasks done

Add validation tests to verify linker annotation and XML descriptor changes #37677

layomia opened this issue Jun 9, 2020 · 3 comments
Assignees
@layomia @joperezr
Labels
area-System.Runtime linkable-framework Issues associated with delivering a linker friendly framework
Projects
Linker optimization work
Milestone
5.0.0

Comments

@layomia
Copy link
Contributor

layomia commented Jun 9, 2020 •
edited by joperezr
Loading

After #37258 is implemented, we should circle back and add tests for previous changes:

Any linker-related changes following the completion of #37258 should be validated with the new test infrastructure.

cc @joperezr @eerhardt
@layomia layomia added the linkable-framework Issues associated with delivering a linker friendly framework label Jun 9, 2020
@layomia layomia added this to the 5.0 milestone Jun 9, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. Please help me learn by adding exactly one area label.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jun 9, 2020
@layomia layomia removed the untriaged New issue has not been triaged by the area owner label Jun 9, 2020
@layomia layomia mentioned this issue Jun 9, 2020
Merged
@eerhardt eerhardt added this to Committed in Linker optimization work Jun 9, 2020
@layomia
Copy link
Contributor Author

layomia commented Jun 16, 2020

The change in #37083 doesn't need a linker test because it removed the use of a type that would have been trimmed out.

This was referenced Jun 16, 2020
Merged
Merged
This was referenced Jun 18, 2020
Merged
Merged
Merged
@eerhardt eerhardt moved this from Committed to In progress in Linker optimization work Jun 19, 2020
@joperezr
Copy link
Member

Closing as this is done now. Check initial comment for PRs that addressed each item.

Linker optimization work automation moved this from In progress to Done Jul 22, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

@joperezr joperezr

Labels
area-System.Runtime linkable-framework Issues associated with delivering a linker friendly framework
Projects
Linker optimization work
  
Done
Milestone
5.0.0
Development

No branches or pull requests
4 participants
@jeffschwMSFT @layomia @joperezr @Dotnet-GitSync-Bot