-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trimming tests for System.ComponentModel.TypeConverter changes #38066
Conversation
Tagging subscribers to this area: @safern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the best way to test the change in https://github.com/dotnet/runtime/pull/37402/files#diff-64cb2690a89a375e7a29b0c7d3651ba5R704.
src/libraries/System.ComponentModel.TypeConverter/tests/TrimmingTests/ComObjectTypeTest.cs
Show resolved
Hide resolved
src/libraries/System.ObjectModel/tests/TrimmingTests/TypeDescriptionProviderAttributeCtor.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/TrimmingTests/DefaultValueAttributeCtorTest.cs
Show resolved
Hide resolved
src/libraries/System.ComponentModel.TypeConverter/tests/TrimmingTests/ComObjectTypeTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ObjectModel/tests/TrimmingTests/TypeDescriptionProviderAttributeCtor.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.ObjectModel/tests/TrimmingTests/TypeDescriptionProviderAttributeCtor.cs
Outdated
Show resolved
Hide resolved
These would be tests for the following: runtime/src/libraries/System.ComponentModel.TypeConverter/src/ILLinkTrim_LibraryBuild.xml Lines 9 to 12 in a8d8b4a
I don't know how to test this without writing C/C++ code. Maybe @vitek-karas or @elinor-fung would know? Also, it might make sense to ensure that the |
src/libraries/System.Runtime/tests/TrimmingTests/DefaultValueAttributeCtorTest.cs
Outdated
Show resolved
Hide resolved
...libraries/System.ObjectModel/tests/TrimmingTests/TypeDescriptionProviderAttributeCtorTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/TrimmingTests/DefaultValueAttributeCtorTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/TrimmingTests/DefaultValueAttributeCtorTest.cs
Outdated
Show resolved
Hide resolved
I think those types are only used during COM activation - activating either a native or managed COM server should exercise them. The problem with a managed COM server is that I'm not sure how building one fits within the testing infrastructure, since we don't/can't use framework references like a normal build considering they are the things under test. Usually, building a managed COM server would make use of the native |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elinor-fung thanks for the reply. I've logged an issue to address the tests - #38417. |
Contributes to #37677 (Strip the ILLinkTrim.xml file from the System.ComponentModel.TypeConverter assembly - #37402)