Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux/arm build warning with unw_getcontext #38652

Closed
BruceForstall opened this issue Jul 1, 2020 · 3 comments · Fixed by #38971
Closed

Linux/arm build warning with unw_getcontext #38652

BruceForstall opened this issue Jul 1, 2020 · 3 comments · Fixed by #38971
Labels
arch-arm32 area-PAL-coreclr os-linux Linux OS (any supported distro) untriaged New issue has not been triaged by the area owner

Comments

@BruceForstall
Copy link
Member

In file included from /__w/1/s/src/coreclr/src/pal/src/exception/seh.cpp:407:
/__w/1/s/src/coreclr/src/pal/src/exception/seh-unwind.cpp:321:10: warning: use of SP or PC in the list is deprecated [-Winline-asm]
    st = unw_getcontext(&unwContext);
         ^
/__w/1/s/artifacts/obj/coreclr/Linux.arm.Debug/src/pal/src/libunwind/include/libunwind-common.h:127:29: note: expanded from macro 'unw_getcontext'
#define unw_getcontext(uc)              unw_tdep_getcontext(uc)
                                        ^
/__w/1/s/src/coreclr/src/pal/src/libunwind/include/libunwind-arm.h:288:6: note: expanded from macro 'unw_tdep_getcontext'
    "stmia %[base], {r0-r15}\n"                                         \
     ^
<inline asm>:5:1: note: instantiated into assembly here
stmia r0, {r0-r15}
^
1 warning generated.

This came up before, in #5595, where it was stated that the behavior is acceptable/required for libunwind. The fix before was to suppress the warning by avoiding inlining (apparently). Somehow, that fix isn't good enough anymore.

Example: https://dev.azure.com/dnceng/public/_build/results?buildId=712094&view=logs&j=7c52437f-2051-5ead-95de-b55e3296cb61&t=8db66bc6-175f-59c5-6a1e-742f332c2bdf

@janvorli

@BruceForstall BruceForstall added arch-arm32 os-linux Linux OS (any supported distro) labels Jul 1, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels Jul 1, 2020
@janvorli
Copy link
Member

janvorli commented Jul 7, 2020

@BruceForstall the change in #5595 changed that warning to not to be reported as an error and cause a build failure. Based on what I can see in the log from the build you have referenced, it is still not causing the build to fail.

@BruceForstall
Copy link
Member Author

@janvorli Correct, it is not causing a build failure. I thought (assumed) the previous "fix" suppressed even this warning, so as not to confuse people (like me) who were searching for an actual failure. If the warning must remain, it's unfortunate, because it's confusing to see warnings like this.

@janvorli
Copy link
Member

janvorli commented Jul 7, 2020

I think it should be possible to disable that warning. I don't remember why it was not done before.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm32 area-PAL-coreclr os-linux Linux OS (any supported distro) untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants