Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for RHEL6 for .NET 5+ #423

Closed
jkotas opened this issue Dec 1, 2019 · 6 comments · Fixed by #1648
Closed

Drop support for RHEL6 for .NET 5+ #423

jkotas opened this issue Dec 1, 2019 · 6 comments · Fixed by #1648
Labels
area-Infrastructure os-linux Linux OS (any supported distro)
Milestone

Comments

@jkotas
Copy link
Member

jkotas commented Dec 1, 2019

https://access.redhat.com/support/policy/updates/errata/#Maintenance_Support_2_Phase has Product Retirement for RHEL6 on November 30, 2020.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 1, 2019
@jkotas
Copy link
Member Author

jkotas commented Dec 1, 2019

Confirmed over email with @richlander

@jkotas
Copy link
Member Author

jkotas commented Dec 1, 2019

Working around missing features in 10+ year old Linux kernel is getting more and more painful, e.g. #420 (comment).

@wfurt
Copy link
Member

wfurt commented Dec 5, 2019

what is next step @jkotas? Should we remove builds and test runs?

@jkotas
Copy link
Member Author

jkotas commented Dec 5, 2019

Right.

@ViktorHofer
Copy link
Member

Those are already removed so I'm closing the issue. Let me know if we should re-open in case we need to remove source code as well.

@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Dec 17, 2019
@ViktorHofer ViktorHofer modified the milestones: 3.1.x, 5.0 Dec 17, 2019
@jkotas
Copy link
Member Author

jkotas commented Dec 17, 2019

Yes, it would be nice to mop-up RedHat 6 related code:

Search for "rhel6":

                if ((line.find(rhel6Prefix) == 0) || (line.find(centos6Prefix) == 0))	d:\runtime\src\installer\corehost\common\pal.unix.cpp
#   |   rhel6   |           rhel.6-x64              |	d:\runtime\src\coreclr\init-distro-rid.sh
                pal::string_t rhel6Prefix(_X("Red Hat Enterprise Linux Server release 6."));	d:\runtime\src\installer\corehost\common\pal.unix.cpp
        // RHEL6 uses a version of OpenSSL that (empirically) doesn't support designated responders.	d:\runtime\src\libraries\System.Security.Cryptography.X509Certificates\tests\RevocationTests\DynamicRevocationTests.cs
        // (There's a chance that we should be passing in extra stuff, but RHEL6 is the only platform	d:\runtime\src\libraries\System.Security.Cryptography.X509Certificates\tests\RevocationTests\DynamicRevocationTests.cs

Search for "RedHatFamily6":

        private static readonly bool s_supportsDesignatedResponder = PlatformDetection.IsNotRedHatFamily6;	d:\runtime\src\libraries\System.Security.Cryptography.X509Certificates\tests\RevocationTests\DynamicRevocationTests.cs
                   return PlatformDetection.IsNotRedHatFamily6 && (NativeLibrary.TryLoad("libgdiplus.so", out _) || NativeLibrary.TryLoad("libgdiplus.so.0", out _));	d:\runtime\src\libraries\Common\tests\CoreFx.Private.TestUtilities\System\PlatformDetection.cs
        public static bool IsRedHatFamily6 => IsRedHatFamilyAndVersion(6);	d:\runtime\src\libraries\Common\tests\CoreFx.Private.TestUtilities\System\PlatformDetection.Unix.cs
        public static bool IsNotRedHatFamily6 => !IsRedHatFamily6;	d:\runtime\src\libraries\Common\tests\CoreFx.Private.TestUtilities\System\PlatformDetection.Unix.cs
        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotRedHatFamily6))]	d:\runtime\src\libraries\System.Diagnostics.Process\tests\ProcessTests.Unix.cs
        public static bool GetIsDrawingSupported() => /* ActiveIssue(24525) */ PlatformDetection.IsNotRedHatFamily6 && PlatformDetection.IsDrawingSupported;	d:\runtime\src\libraries\System.Drawing.Primitives\tests\Helpers.cs
        static bool IsBindMountSupported => RuntimeInformation.IsOSPlatform(OSPlatform.Linux) && !PlatformDetection.IsInContainer && !PlatformDetection.IsRedHatFamily6;	d:\runtime\src\libraries\System.IO.FileSystem\tests\Directory\Delete.cs
        static bool IsBindMountSupported => RuntimeInformation.IsOSPlatform(OSPlatform.Linux) && !PlatformDetection.IsInContainer && !PlatformDetection.IsRedHatFamily6;	d:\runtime\src\libraries\System.IO.FileSystem\tests\File\Delete.cs
        [ConditionalFact(typeof(PlatformDetection), "IsNotRedHatFamily6")]	d:\runtime\src\libraries\System.IO.Pipes\tests\AnonymousPipeTests\AnonymousPipeTest.Specific.cs
        [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotRedHatFamily6))]	d:\runtime\src\libraries\System.Runtime.Extensions\tests\System\Runtime\ProfileOptimization.cs

@jkotas jkotas reopened this Dec 17, 2019
Infrastructure - Product Functionality & Features automation moved this from To do to In progress Dec 17, 2019
Infrastructure - Product Functionality & Features automation moved this from In progress to Done Jan 12, 2020
jkotas added a commit that referenced this issue Jan 12, 2020
Fixes #423
Closes dotnet/corefx#24525
Closes dotnet/corefx#37739
Closes dotnet/corefx#31792
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure os-linux Linux OS (any supported distro)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants