-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Regressions in Span scenarios #44817
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
There are only 4 commits in this period and #44574 leaps out because it touches Span. @trylek @GrabYourPitchforks thoughts? |
Unassigning from myself, as I don't know how to begin investigating this. We didn't add new logic - we only removed existing logic. My best guess is that: (a) deleting some code changed how the remaining codegen was aligned; or (b) the PGO data for this method is stale and we need to wait for new PGO data to be generated. In either case I think somebody from the JIT side would be a better candidate to take a look at this. |
That makes sense. @dotnet/jit-contrib any thoughts about this - could the changes in #44574 have affected the efficiency of https://github.com/dotnet/performance/blob/de2546b730da4b7904f6e7e051d93c5d733c6516/src/benchmarks/micro/libraries/System.Buffers/ReadOnlySequenceTests.cs#L48 (which is essentially the body of all these tests -- save the UTF8 ones, who may do similar work) |
Run Information
Regressions in System.Buffers.Tests.ReadOnlySequenceTests
Historical Data in Reporting System
Repro
Histogram
System.Buffers.Tests.ReadOnlySequenceTests.FirstSpanMemory
System.Buffers.Tests.ReadOnlySequenceTests.FirstSpanArray
System.Buffers.Tests.ReadOnlySequenceTests.FirstSpanTenSegments
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Text.Json.Tests.Perf_Basic
Historical Data in Reporting System
Repro
Histogram
System.Text.Json.Tests.Perf_Basic.WriteBasicUtf8(Formatted: True, SkipValidation: True, DataSize: 100000)
System.Text.Json.Tests.Perf_Basic.WriteBasicUtf8(Formatted: True, SkipValidation: False, DataSize: 100000)
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Buffers.Tests.ReadOnlySequenceTests
Historical Data in Reporting System
Repro
Histogram
System.Buffers.Tests.ReadOnlySequenceTests.FirstSpanSingleSegment
System.Buffers.Tests.ReadOnlySequenceTests.FirstSpanTenSegments
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: