Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the experimental Utf8String type and tests from the runtime repo #44574

Merged
merged 4 commits into from
Nov 12, 2020

Conversation

trylek
Copy link
Member

@trylek trylek commented Nov 12, 2020

I'm proposing to remove the Utf8String and Utf8Span types and the
System.Utf8String.Experimental tests from the runtime repo as according to
JanK's clarifications these types and tests are currently treated as experimental
and belong to the runtimelab, not to the "production" runtime repo. From a
practical perspective, we're hitting crashes in the Utf8String tests when using
System.Private.CoreLib compiled with Crossgen2 which doesn't yet implement
the Utf8String-related typesystem logic.

Thanks

Tomas

Related to: #41521

@ghost
Copy link

ghost commented Nov 12, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.


Issue meta data

Issue content: I'm proposing to remove the Utf8String and Utf8Span types and the System.Utf8String.Experimental tests from the runtime repo as according to JanK's clarifications these types and tests are currently treated as experimental and belong to the runtimelab, not to the "production" runtime repo. From a practical perspective, we're hitting crashes in the Utf8String tests when using System.Private.CoreLib compiled with Crossgen2 which doesn't yet implement the Utf8String-related typesystem logic.

Thanks

Tomas

Related to: #41521

Issue author: trylek
Assignees: -
Milestone: [object Object]

@GrabYourPitchforks
Copy link
Member

GrabYourPitchforks commented Nov 12, 2020

Don't forget to remove the file runtime/src/libraries/System.Private.CoreLib/src/System/Char8.cs and all references to the Char8 type.

If you search the repo's .cs files for FEATURE_UTF8STRING, you'll find some lingering references in Utf8Utility.cs, Span.cs, Memory.cs, and related files. Those can all be removed as well.

@trylek trylek changed the title WIP: remove the experimental Utf8String type and tests from the runtime repo Remove the experimental Utf8String type and tests from the runtime repo Nov 12, 2020
@trylek
Copy link
Member Author

trylek commented Nov 12, 2020

Merging now to unblock my follow-up Crossgen2 efforts. I'll be happy to address any additional feedback in a follow-up PR.

@trylek trylek merged commit 77ba2bd into dotnet:master Nov 12, 2020
@trylek trylek deleted the Utf8String branch November 12, 2020 23:41
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Core-Runtime .net 9
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants