Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono][Android] Some runtime test groups are too big to run on Android devices #45568

Closed
Tracked by #52782
fanyang-mono opened this issue Dec 3, 2020 · 4 comments · Fixed by #49662
Closed
Tracked by #52782
Assignees
Milestone

Comments

@fanyang-mono
Copy link
Member

fanyang-mono commented Dec 3, 2020

Some runtime test groups are too big to run on Android devices. Need to split them up. For example,

  • JIT.HardwareIntrinsics
  • JIT.Methodical.eh
  • JIT.IL_Conformance
  • JIT
  • JIT.Regression
  • PayloadGroup0
@fanyang-mono fanyang-mono added this to the 6.0.0 milestone Dec 3, 2020
@fanyang-mono fanyang-mono self-assigned this Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Some runtime test groups are too big to run on Android devices. Need to split them up. For example,

  • JIT.HardwareIntrinsics
  • JIT.Methodical.eh
  • JIT.IL_Conformance
  • JIT
Author: fanyang-mono
Assignees: fanyang-mono
Labels:

area-Infrastructure

Milestone: 6.0.0

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 3, 2020
@naricc
Copy link
Member

naricc commented Dec 7, 2020

What do we actually have to do to split them up? Is it just a logical thing inside the msbuild files somewhere, or are a reorganization of the directory structure in /src/tests/JIT?

@trylek
Copy link
Member

trylek commented Dec 8, 2020

@naricc It's just a "logical thing inside the msbuild files", mostly driven by the file

https://github.com/dotnet/runtime/blob/master/src/tests/Common/testgrouping.proj

According to my recollection @echesakovMSFT implemented or last updated this logic last year more or less on experimental basis to tune (then) CoreCLR repo test performance.

This is known to be maintenance pain and fragile scheme w.r.t. new platform bring-up (as Fan's efforts just confirmed) and we're generally hoping to get rid of that at some point, either by automating the splitting or by making it unnecessary, perhaps thanks to some future changes in the Helix protocol that would reduce the work item overhead within a single run, @MattGal might know whether something like this could be doable.

The CoreCLR test portfolio is also generally believed to be poorly understood in terms of code coverage of the runtime and other parts of the system; I believe that as a medium-term goal we should design a plan to audit the CoreCLR test set and measure some form of "cost / effect" ratio with the aim to optimize the set for performance without degrading the general level of testing.

@fanyang-mono
Copy link
Member Author

I agree with your idea that we should audit the runtime tests, in general. When should we aim on doing that? Also, I would like to know what we need to get ready before getting rid of this manually split scheme?

@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Mar 3, 2021
@fanyang-mono fanyang-mono changed the title Some runtime test groups are too big to run on Android devices [Mono Android] Some runtime test groups are too big to run on Android devices May 14, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 18, 2021
@fanyang-mono fanyang-mono changed the title [Mono Android] Some runtime test groups are too big to run on Android devices [Mono][Android] Some runtime test groups are too big to run on Android devices Jun 18, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants