Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mono runtime pack should include include/ directory on desktop, too #46461

Closed
lambdageek opened this issue Dec 30, 2020 · 1 comment · Fixed by #69719
Closed

Mono runtime pack should include include/ directory on desktop, too #46461

lambdageek opened this issue Dec 30, 2020 · 1 comment · Fixed by #69719
Labels
area-Build-mono
Projects
Infrastructure Backlog Mono
Milestone
7.0.0

Comments

@lambdageek
Copy link
Member

We include the include/ directory with the mono embedding API headers in the mobile runtime packs, but not the Microsoft.NETCore.App.Runtime.Mono packs

runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj

Lines 82 to 86 in 8d7e074

<RuntimeFiles Condition="'$(TargetsMobile)' == 'true'"
Include="@(MonoIncludeFiles)"
ExcludeFromDataFiles="true">
<TargetPath>runtimes/$(RuntimeIdentifier)/native/include/%(RecursiveDir)</TargetPath>
</RuntimeFiles>

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Setup untriaged New issue has not been triaged by the area owner labels Dec 30, 2020
@lambdageek lambdageek added area-Build-mono and removed area-Setup untriaged New issue has not been triaged by the area owner labels Dec 30, 2020
@lambdageek lambdageek added this to the 6.0.0 milestone Dec 30, 2020
@lambdageek
Copy link
Member Author

/cc @steveisok

@lambdageek lambdageek mentioned this issue Jan 14, 2021
Open
5 tasks
@steveisok steveisok modified the milestones: 6.0.0, 7.0.0 Jul 26, 2021
directhex added a commit to directhex/runtime that referenced this issue May 24, 2022
@directhex
Include include folder in runtime pack on all Mono platforms
b350d9d 
Closes: dotnet#46461
@directhex directhex mentioned this issue May 24, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 24, 2022
directhex added a commit that referenced this issue Jun 8, 2022
@directhex
Include include folder in runtime pack on all Mono platforms (#69719)
0c4fae1 
Closes: #46461
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Build-mono
Projects
No open projects
Infrastructure Backlog Mono
  
Awaiting triage
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Include include folder in runtime pack on all Mono platforms directhex/runtime
3 participants
@steveisok @lambdageek @Dotnet-GitSync-Bot