Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket.ReceiveMessageFrom(saea) does not respect buffer offset on Windows #47637

Closed
antonfirsov opened this issue Jan 29, 2021 · 2 comments · Fixed by #47642
Closed

Socket.ReceiveMessageFrom(saea) does not respect buffer offset on Windows #47637

antonfirsov opened this issue Jan 29, 2021 · 2 comments · Fixed by #47642
Labels
area-System.Net.Sockets bug
Milestone
6.0.0

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Jan 29, 2021 •
edited
Loading

Discovered in #46285 (comment), to reproduce it's enough to modify the test case to use offset as it has been done in the PR, so it passes an offset to SocketAsyncEventArgs.SetBuffer()

The modified EAP case fails on Windows, but passes on Linux.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Net untriaged New issue has not been triaged by the area owner labels Jan 29, 2021
@ghost

This comment has been minimized.

Sign in to view
@antonfirsov antonfirsov mentioned this issue Jan 29, 2021
Merged
@ghost
Copy link

ghost commented Jan 29, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Discovered in #46285 (comment), to reproduce it's enough to modify the test case as it was done in the PR.

The modified EAP case fails on Windows, but passes on Linux.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Sockets, untriaged
Milestone: -

@antonfirsov antonfirsov added this to the 6.0.0 milestone Jan 29, 2021
@antonfirsov antonfirsov added bug and removed untriaged New issue has not been triaged by the area owner labels Jan 29, 2021
@antonfirsov antonfirsov changed the title Socket.ReceiveMessageFrom(saea) does not respect offset on Windows Socket.ReceiveMessageFrom(saea) does not respect buffer offset on Windows Jan 29, 2021
antonfirsov added a commit to antonfirsov/runtime that referenced this issue Jan 29, 2021
@antonfirsov
fix dotnet#47637
7bf803d
@antonfirsov antonfirsov mentioned this issue Jan 29, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 29, 2021
antonfirsov added a commit that referenced this issue Feb 2, 2021
@antonfirsov
Respect offset in Socket.ReceiveMessageFrom(saea) on Windows (#47642)
f47c1b5 
Fixes #47637, and adds ReceiveSent_UDP_Success test to both ReceiveFrom and ReceiveMessageFrom
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net.Sockets bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Respect offset in Socket.ReceiveMessageFrom(saea) on Windows antonfirsov/runtime
1 participant
@antonfirsov